Skip to content

Add client authentication support for ticdc#16692

Merged
ti-chi-bot[bot] merged 20 commits intopingcap:masterfrom
CharlesCheung96:cdc-support-auth
May 13, 2024
Merged

Add client authentication support for ticdc#16692
ti-chi-bot[bot] merged 20 commits intopingcap:masterfrom
CharlesCheung96:cdc-support-auth

Conversation

@CharlesCheung96
Copy link
Copy Markdown
Contributor

@CharlesCheung96 CharlesCheung96 commented Feb 28, 2024 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 28, 2024
@Oreoxmt Oreoxmt added the translation/doing This PR’s assignee is translating this PR. label Feb 29, 2024
@ti-chi-bot ti-chi-bot Bot removed the missing-translation-status This PR does not have translation status info. label Feb 29, 2024
@Oreoxmt Oreoxmt added missing-translation-status This PR does not have translation status info. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. v8.1 This PR/issue applies to TiDB v8.1. labels Feb 29, 2024
@hfxsd hfxsd removed the missing-translation-status This PR does not have translation status info. label Feb 29, 2024
flowbehappy
flowbehappy reviewed Mar 29, 2024
View reviewed changes
Comment thread ticdc/ticdc-client-authentication.md Outdated
flowbehappy
flowbehappy reviewed Mar 29, 2024
View reviewed changes
Comment thread ticdc/ticdc-client-authentication.md Outdated
flowbehappy
flowbehappy reviewed Mar 29, 2024
View reviewed changes
Comment thread ticdc/ticdc-client-authentication.md Outdated
flowbehappy
flowbehappy reviewed Mar 29, 2024
View reviewed changes
Comment thread ticdc/ticdc-server-config.md Outdated
CharlesCheung96 and others added 2 commits April 2, 2024 10:49
@CharlesCheung96 @flowbehappy
Update ticdc/ticdc-server-config.md
4a9b317 
Co-authored-by: Flowyi <flowbehappy@gmail.com>
@CharlesCheung96
address comments
c15b32f
CharlesCheung96
CharlesCheung96 commented Apr 2, 2024
View reviewed changes
Comment thread ticdc/ticdc-client-authentication.md Outdated
CharlesCheung96
CharlesCheung96 commented Apr 2, 2024
View reviewed changes
Comment thread ticdc/ticdc-client-authentication.md Outdated
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 9, 2024

@flowbehappy: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Oreoxmt Oreoxmt self-assigned this Apr 10, 2024
@Oreoxmt Oreoxmt added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Apr 16, 2024
@Oreoxmt Oreoxmt mentioned this pull request Apr 16, 2024
Merged
16 tasks
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 18, 2024
qiancai
qiancai reviewed Apr 23, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Comment thread ticdc/ticdc-client-authentication.md Outdated
Comment thread ticdc/ticdc-client-authentication.md Outdated
Comment thread ticdc/ticdc-client-authentication.md Outdated
Comment thread ticdc/ticdc-client-authentication.md Outdated
Comment thread ticdc/ticdc-client-authentication.md Outdated
Comment thread ticdc/ticdc-client-authentication.md Outdated
Comment thread ticdc/ticdc-server-config.md Outdated
@Oreoxmt @qiancai
Apply suggestions from code review
a114564 
Co-authored-by: Grace Cai <qqzczy@126.com>
@Oreoxmt Oreoxmt requested a review from qiancai April 24, 2024 08:44
qiancai
qiancai reviewed Apr 24, 2024
View reviewed changes
Comment thread ticdc/ticdc-client-authentication.md Outdated
@CharlesCheung96 @qiancai
Update ticdc/ticdc-client-authentication.md
09c9025 
Co-authored-by: Grace Cai <qqzczy@126.com>
@CharlesCheung96
Copy link
Copy Markdown
Contributor Author

CharlesCheung96 commented Apr 28, 2024

/hold

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 28, 2024
@CharlesCheung96 CharlesCheung96 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2024
Oreoxmt
Oreoxmt reviewed Apr 29, 2024
View reviewed changes
Comment thread ticdc/ticdc-client-authentication.md Outdated
flowbehappy
flowbehappy reviewed Apr 30, 2024
View reviewed changes
Comment thread ticdc/ticdc-client-authentication.md Outdated
@CharlesCheung96 @flowbehappy
Update ticdc/ticdc-client-authentication.md
ac76183 
Co-authored-by: Flowyi <flowbehappy@gmail.com>
@Oreoxmt Oreoxmt requested a review from qiancai May 6, 2024 03:00
@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 6, 2024
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-18 02:38:20.593732894 +0000 UTC m=+478519.704779343: ☑️ agreed by Oreoxmt.
  • 2024-05-06 07:44:55.308241725 +0000 UTC m=+861649.065377297: ☑️ agreed by qiancai.

qiancai
qiancai reviewed May 6, 2024
View reviewed changes
Comment thread ticdc/ticdc-client-authentication.md Outdated
qiancai
qiancai approved these changes May 6, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@Oreoxmt @qiancai
Apply suggestions from code review
9072c67 
Co-authored-by: Grace Cai <qqzczy@126.com>
@Oreoxmt
Copy link
Copy Markdown
Collaborator

Oreoxmt commented May 13, 2024

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label May 13, 2024
@ti-chi-bot ti-chi-bot Bot merged commit d2d0341 into pingcap:master May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flowbehappy flowbehappy flowbehappy approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@qiancai qiancai qiancai approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels

approved area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v8.1 This PR/issue applies to TiDB v8.1.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@CharlesCheung96 @Oreoxmt @flowbehappy @qiancai @hfxsd