Skip to content

Add client authentication support for ticdc#17227

Merged
ti-chi-bot[bot] merged 5 commits intopingcap:masterfrom
Oreoxmt:translate/docs-cn-16692
May 13, 2024
Merged

Add client authentication support for ticdc#17227
ti-chi-bot[bot] merged 5 commits intopingcap:masterfrom
Oreoxmt:translate/docs-cn-16692

Conversation

@Oreoxmt
Copy link
Copy Markdown
Collaborator

@Oreoxmt Oreoxmt commented Apr 16, 2024

What is changed, added or deleted? (Required)

v8.1.0 supports TiCDC client authentication.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. v8.1 This PR/issue applies to TiDB v8.1. labels Apr 16, 2024
@Oreoxmt Oreoxmt self-assigned this Apr 16, 2024
@Oreoxmt
Copy link
Copy Markdown
Collaborator Author

Oreoxmt commented Apr 16, 2024

/cc @qiancai @CharlesCheung96

@ti-chi-bot ti-chi-bot Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 16, 2024
@ti-chi-bot ti-chi-bot Bot requested review from CharlesCheung96 and qiancai April 16, 2024 08:10
Comment thread ticdc/ticdc-client-authentication.md Outdated
Comment thread ticdc/ticdc-client-authentication.md Outdated
Comment thread ticdc/ticdc-client-authentication.md Outdated
Comment thread ticdc/ticdc-client-authentication.md Outdated
Comment thread ticdc/ticdc-client-authentication.md Outdated
Comment thread ticdc/ticdc-client-authentication.md Outdated
Comment thread ticdc/ticdc-client-authentication.md Outdated
Co-authored-by: Grace Cai <qqzczy@126.com>
Comment thread ticdc/ticdc-client-authentication.md
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 26, 2024

@CharlesCheung96: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Comment thread ticdc/ticdc-client-authentication.md Outdated
Comment thread ticdc/ticdc-client-authentication.md Outdated
Comment thread ticdc/ticdc-client-authentication.md Outdated
@Oreoxmt Oreoxmt requested a review from qiancai May 6, 2024 03:00
Comment thread ticdc/ticdc-client-authentication.md Outdated
Co-authored-by: Grace Cai <qqzczy@126.com>
@Oreoxmt Oreoxmt requested a review from qiancai May 8, 2024 10:26
Copy link
Copy Markdown
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-13 07:41:59.739666433 +0000 UTC m=+1466273.496802005: ☑️ agreed by qiancai.

@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 13, 2024
@Oreoxmt Oreoxmt added the lgtm label May 13, 2024
@Oreoxmt
Copy link
Copy Markdown
Collaborator Author

Oreoxmt commented May 13, 2024

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label May 13, 2024
@ti-chi-bot ti-chi-bot Bot merged commit 17f221d into pingcap:master May 13, 2024
dveeden pushed a commit to dveeden/docs that referenced this pull request May 15, 2024
@Oreoxmt Oreoxmt deleted the translate/docs-cn-16692 branch July 10, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v8.1 This PR/issue applies to TiDB v8.1.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants