Skip to content

system-variables: add doc for tidb_max_dist_task_nodes#19878

Merged
ti-chi-bot[bot] merged 12 commits intopingcap:masterfrom
tangenta:sysvar-max-dist-nodes
Apr 8, 2025
Merged

system-variables: add doc for tidb_max_dist_task_nodes#19878
ti-chi-bot[bot] merged 12 commits intopingcap:masterfrom
tangenta:sysvar-max-dist-nodes

Conversation

@tangenta
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 20, 2025
- 类型:整数型
- 默认值:`-1`
- 范围:`-1` 或 `[1, 128]`
- 该变量定义了分布式框架任务可使用的最大 TiDB 节点数上限。默认值为 `-1`,表示自动模式。在此模式下,系统将自动选择合适的节点数量。
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里建议补充自动计算节点数的算法,便于用户自己算

@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 20, 2025

@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hfxsd hfxsd added translation/doing This PR’s assignee is translating this PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. and removed missing-translation-status This PR does not have translation status info. labels Feb 21, 2025
@hfxsd hfxsd self-assigned this Feb 21, 2025
@hfxsd hfxsd added v9.0-beta.1 This PR/issue applies to TiDB v9.0-beta.1. for-release This PR relates to a TiDB release but does not have a tracked feature. labels Feb 21, 2025
@hfxsd hfxsd changed the title system-variables: add doc for tidb_max_dist_task_nodes system-variables: add doc for tidb_max_dist_task_nodes Mar 31, 2025
Signed-off-by: tangenta <tangenta@126.com>
Co-authored-by: Frank945946 <108602632+Frank945946@users.noreply.github.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 8, 2025

@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 8, 2025
@hfxsd hfxsd requested a review from lilin90 April 8, 2025 07:10
@hfxsd hfxsd reopened this Apr 8, 2025
@lilin90 lilin90 requested a review from Copilot April 8, 2025 07:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@lilin90
Copy link
Member

lilin90 commented Apr 8, 2025

/bot-review

- 类型:整数型
- 默认值:`-1`
- 范围:`-1` 或 `[1, 128]`
- 该变量定义了分布式框架任务可使用的 TiDB 节点数上限。默认值为 `-1`,表示自动模式。在自动模式下,系统将按照 `min(3, tikv_nodes / 3)` 动态地计算该值,其中 `tikv_nodes` 表示集群中 TiKV 节点的数量。
Copy link

@github-actions github-actions bot Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

自动模式的描述不够清晰,建议明确说明计算逻辑和适用场景。

Suggested change
- 该变量定义了分布式框架任务可使用的 TiDB 节点数上限。默认值为 `-1`,表示自动模式。在自动模式下,系统将按照 `min(3, tikv_nodes / 3)` 动态地计算该值,其中 `tikv_nodes` 表示集群中 TiKV 节点的数量。
该变量定义了分布式框架任务可使用的 TiDB 节点数上限。默认值为 `-1`,表示自动模式。在自动模式下,系统会根据集群规模动态计算该值,计算公式为 `min(3, tikv_nodes / 3)`,其中 `tikv_nodes` 表示集群中 TiKV 节点的数量。

@github-actions
Copy link

github-actions bot commented Apr 8, 2025

✅ AI review completed, 3 comments generated.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 8, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 8, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 8, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-04-08 08:38:03.476202137 +0000 UTC m=+2159177.160438233: ☑️ agreed by lilin90.
  • 2025-04-08 08:41:45.337199053 +0000 UTC m=+2159399.021435150: ☑️ agreed by hfxsd.

@hfxsd
Copy link
Collaborator

hfxsd commented Apr 8, 2025

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 8, 2025
@ti-chi-bot ti-chi-bot bot merged commit 55f1bed into pingcap:master Apr 8, 2025
7 checks passed
@hfxsd hfxsd added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Feb 26, 2026
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #21393.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved for-release This PR relates to a TiDB release but does not have a tracked feature. lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v9.0-beta.1 This PR/issue applies to TiDB v9.0-beta.1.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants