system-variables: add doc for tidb_max_dist_task_nodes#20718
system-variables: add doc for tidb_max_dist_task_nodes#20718ti-chi-bot[bot] merged 7 commits intopingcap:masterfrom
tidb_max_dist_task_nodes#20718Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @hfxsd, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request adds documentation for the tidb_max_dist_task_nodes system variable. This variable, new in v9.0.0, controls the maximum number of TiDB nodes that the Distributed eXecution Framework (DXF) can use. The documentation includes the variable's scope, persistence, applicability to hints, type, default value, range, and a detailed explanation of its behavior, including its interaction with the tidb_service_scope variable. The PR also includes a note and an example to clarify how tidb_service_scope affects the number of TiDB nodes used by DXF.
Highlights
- Documentation: Adds documentation for the
tidb_max_dist_task_nodessystem variable. - New System Variable: Documents the behavior of the new
tidb_max_dist_task_nodessystem variable introduced in v9.0.0. - DXF: Explains how
tidb_max_dist_task_nodesaffects the Distributed eXecution Framework (DXF).
Changelog
- system-variables.md
- Added documentation for the
tidb_max_dist_task_nodessystem variable. - Documented the scope, persistence, applicability to hints, type, default value, and range of
tidb_max_dist_task_nodes. - Explained the interaction between
tidb_max_dist_task_nodesandtidb_service_scope. - Provided an example to illustrate the effect of
tidb_service_scopeon the number of TiDB nodes used by DXF.
- Added documentation for the
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A variable's doc,
Shows its scope and its range,
Knowledge shared wide.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
ti-chi-bot
bot
added
missing-translation-status
There was a problem hiding this comment.
Code Review
The pull request adds documentation for the tidb_max_dist_task_nodes system variable. The documentation is clear and concise, providing a good explanation of the variable's purpose, scope, range, and default value. The note about tidb_service_scope is also helpful for understanding the variable's behavior in different scenarios.
Merge Readiness
The pull request is well-written and the changes are straightforward. I did not find any critical or high severity issues. The pull request appears ready to be merged, but I am unable to approve it. Please have others review and approve this code before merging.
hfxsd
added
translation/from-docs-cn
|
@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Co-authored-by: Frank945946 <108602632+Frank945946@users.noreply.github.com>
hfxsd
added
the
type/compatibility-or-feature-change
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hfxsd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hfxsd
added
the
needs-cherry-pick-release-8.5
|
In response to a cherrypick label: new pull request created to branch |
5 participants
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
tidb_max_dist_task_nodesdocs-cn#19878Do your changes match any of the following descriptions?