Skip to content

docs: clarify Syncpoint changefeed configuration scope - #21838

Merged
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
doc-claw-bot:docs/fix-syncpoint-changefeed
Jul 28, 2026
Merged

docs: clarify Syncpoint changefeed configuration scope#21838
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
doc-claw-bot:docs/fix-syncpoint-changefeed

Conversation

@doc-claw-bot

@doc-claw-bot doc-claw-bot commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

What is changed, added or deleted? (Required)

Clarify that enable-sync-point is a changefeed configuration item rather than a TiCDC server configuration item.

Update the related Syncpoint wording in these docs so readers know the setting belongs to the changefeed configuration file:

  • ticdc/ticdc-upstream-downstream-check.md
  • dr-secondary-cluster.md

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot Bot added contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. labels Jul 28, 2026
@ti-chi-bot ti-chi-bot Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 28, 2026
@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

本次更新统一 Syncpoint 的配置归属表述,并明确备用集群设置已复制完成一致性快照点的方式与周期。

Changes

Syncpoint 文档更新

Layer / File(s) Summary
Syncpoint 配置与流程说明
dr-secondary-cluster.md, ticdc/ticdc-upstream-downstream-check.md
enable-sync-point 明确为 changefeed 配置项,并补充 Changefeed 按 sync-point-interval 设置备用集群一致性快照点的说明。

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed 标题准确概括了将 Syncpoint 配置范围明确为 changefeed 配置的主要改动。
Description check ✅ Passed 描述包含了变更内容、影响版本、相关链接和 AI 参与信息,结构基本完整。
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@doc-claw-bot doc-claw-bot added type/enhancement The issue or PR belongs to an enhancement. area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. labels Jul 28, 2026
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 28, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-07-28 02:12:14.432261069 +0000 UTC m=+1889320.468356135: ☑️ agreed by qiancai.

@qiancai qiancai self-assigned this Jul 28, 2026
@qiancai qiancai added needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed missing-translation-status This PR does not have translation status info. labels Jul 28, 2026
@qiancai

qiancai commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

/approve

@qiancai qiancai added the lgtm label Jul 28, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Jul 28, 2026
@ti-chi-bot
ti-chi-bot Bot merged commit 2ba27b6 into pingcap:master Jul 28, 2026
11 checks passed
@ti-chi-bot

Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #21839.
But this PR has conflicts, please resolve them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. contribution This PR is from a community contributor. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants