Skip to content

Conversation

@superlzs0476
Copy link
Contributor

@superlzs0476 superlzs0476 commented Apr 15, 2020

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@superlzs0476
Copy link
Contributor Author

@cocoyi17 @kissmydb PTAL

@yikeke yikeke requested review from kissmydb and yikeke April 18, 2020 13:37
@yikeke yikeke added needs-cherry-pick-4.0 translation/doing This PR’s assignee is translating this PR. labels Apr 18, 2020
@yikeke yikeke self-assigned this Apr 18, 2020
@yikeke yikeke changed the title How-to/deploy/tiup: Optimized deploy tiup tiup: optimize content and format of tiup deployment doc Apr 18, 2020
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke
Copy link
Contributor

yikeke commented Apr 19, 2020

PTAL @kissmydb

@yikeke yikeke added the status/PTAL This PR is ready for reviewing. label Apr 19, 2020
Copy link
Contributor

@kissmydb kissmydb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@superlzs0476 superlzs0476 merged commit 33f78a1 into pingcap:master Apr 19, 2020
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Apr 19, 2020
* Optimized deploy for tiup docs

* fix some details

* fix some details

* update headings

* Update tiup.md

* fix two links

* remove extra blank lines

* unify code comment format

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: yikeke <yikeke@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Apr 19, 2020

cherry pick to release-4.0 in PR #2815

yikeke added a commit that referenced this pull request Apr 19, 2020
* Optimized deploy for tiup docs

* fix some details

* fix some details

* update headings

* Update tiup.md

* fix two links

* remove extra blank lines

* unify code comment format

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: yikeke <yikeke@pingcap.com>

Co-authored-by: lzs <43946384+superlzs0476@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: yikeke <yikeke@pingcap.com>
@yikeke yikeke added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels May 6, 2020
rleungx pushed a commit to rleungx/docs-cn that referenced this pull request May 22, 2020
* Optimized deploy for tiup docs

* fix some details

* fix some details

* update headings

* Update tiup.md

* fix two links

* remove extra blank lines

* unify code comment format

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: yikeke <yikeke@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants