-
Notifications
You must be signed in to change notification settings - Fork 1.2k
tiup: fix some details in tiup deployment doc #2705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
LGTM |
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
yikeke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kissmydb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
修改 label 的格式
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
lonng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* fix some details * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * fix some details * refine content and format * fix ci * Update tiup.md 修改 label 的格式 * Update tiup.md * Update tiup.md * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update tiup.md * fix a link * Update tiup.md Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: yikeke <yikeke@pingcap.com> Co-authored-by: kissmydb <likun@pingcap.com>
|
cherry pick to release-4.0 in PR #2719 |
* fix some details * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * fix some details * refine content and format * fix ci * Update tiup.md 修改 label 的格式 * Update tiup.md * Update tiup.md * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update tiup.md * fix a link * Update tiup.md Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: yikeke <yikeke@pingcap.com> Co-authored-by: kissmydb <likun@pingcap.com> Co-authored-by: lzs <43946384+superlzs0476@users.noreply.github.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: yikeke <yikeke@pingcap.com> Co-authored-by: kissmydb <likun@pingcap.com>
* fix some details * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * fix some details * refine content and format * fix ci * Update tiup.md 修改 label 的格式 * Update tiup.md * Update tiup.md * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update tiup.md * fix a link * Update tiup.md Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: yikeke <yikeke@pingcap.com> Co-authored-by: kissmydb <likun@pingcap.com>
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.
What is the related PR or file link(s)?