Skip to content

Conversation

@superlzs0476
Copy link
Contributor

@superlzs0476 superlzs0476 commented Apr 10, 2020

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@superlzs0476
Copy link
Contributor Author

@kissmydb @cocoyi17 PTAL

@yikeke yikeke requested a review from kissmydb April 10, 2020 09:36
@yikeke yikeke self-assigned this Apr 10, 2020
@yikeke yikeke added the translation/doing This PR’s assignee is translating this PR. label Apr 10, 2020
@yikeke yikeke self-requested a review April 10, 2020 09:38
@kissmydb
Copy link
Contributor

LGTM

@yikeke yikeke changed the title Fix deploy tiup some details tiup: fix deploy tiup some details Apr 10, 2020
superlzs0476 and others added 7 commits April 10, 2020 21:16
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kissmydb kissmydb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke requested a review from lonng April 13, 2020 02:54
修改 label 的格式
@yikeke yikeke changed the title tiup: fix deploy tiup some details tiup: fix some details in tiup deployment doc Apr 13, 2020
kissmydb and others added 4 commits April 13, 2020 13:55
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke merged commit 359db11 into pingcap:master Apr 13, 2020
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Apr 13, 2020
* fix some details

* Update how-to/deploy/orchestrated/tiup.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* Update how-to/deploy/orchestrated/tiup.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* Update how-to/deploy/orchestrated/tiup.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* Update how-to/deploy/orchestrated/tiup.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* Update how-to/deploy/orchestrated/tiup.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* Update how-to/deploy/orchestrated/tiup.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* fix some details

* refine content and format

* fix ci

* Update tiup.md

修改 label 的格式

* Update tiup.md

* Update tiup.md

* Update how-to/deploy/orchestrated/tiup.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* Update tiup.md

* fix a link

* Update tiup.md

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: yikeke <yikeke@pingcap.com>
Co-authored-by: kissmydb <likun@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Apr 13, 2020

cherry pick to release-4.0 in PR #2719

yikeke added a commit that referenced this pull request Apr 13, 2020
* fix some details

* Update how-to/deploy/orchestrated/tiup.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* Update how-to/deploy/orchestrated/tiup.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* Update how-to/deploy/orchestrated/tiup.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* Update how-to/deploy/orchestrated/tiup.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* Update how-to/deploy/orchestrated/tiup.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* Update how-to/deploy/orchestrated/tiup.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* fix some details

* refine content and format

* fix ci

* Update tiup.md

修改 label 的格式

* Update tiup.md

* Update tiup.md

* Update how-to/deploy/orchestrated/tiup.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* Update tiup.md

* fix a link

* Update tiup.md

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: yikeke <yikeke@pingcap.com>
Co-authored-by: kissmydb <likun@pingcap.com>

Co-authored-by: lzs <43946384+superlzs0476@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: yikeke <yikeke@pingcap.com>
Co-authored-by: kissmydb <likun@pingcap.com>
@yikeke yikeke added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 15, 2020
rleungx pushed a commit to rleungx/docs-cn that referenced this pull request May 22, 2020
* fix some details

* Update how-to/deploy/orchestrated/tiup.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* Update how-to/deploy/orchestrated/tiup.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* Update how-to/deploy/orchestrated/tiup.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* Update how-to/deploy/orchestrated/tiup.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* Update how-to/deploy/orchestrated/tiup.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* Update how-to/deploy/orchestrated/tiup.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* fix some details

* refine content and format

* fix ci

* Update tiup.md

修改 label 的格式

* Update tiup.md

* Update tiup.md

* Update how-to/deploy/orchestrated/tiup.md

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* Update tiup.md

* fix a link

* Update tiup.md

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: yikeke <yikeke@pingcap.com>
Co-authored-by: kissmydb <likun@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants