Skip to content

br: add backup and resotre from s3 with BR #2802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 6, 2020
Merged

br: add backup and resotre from s3 with BR #2802

merged 4 commits into from
May 6, 2020

Conversation

@shuijing198799
Copy link
Contributor

@shuijing198799 shuijing198799 commented Apr 17, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Add backup and restore with BR from Amazon S3 storage

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@shuijing198799 shuijing198799 requested a review from 3pointer April 17, 2020 07:49
@TomShawn TomShawn self-assigned this Apr 17, 2020
@TomShawn TomShawn added needs-cherry-pick-3.1 translation/doing This PR’s assignee is translating this PR. labels Apr 17, 2020
3pointer
3pointer reviewed Apr 17, 2020
View reviewed changes
3pointer
3pointer reviewed Apr 17, 2020
View reviewed changes
3pointer
3pointer reviewed Apr 17, 2020
View reviewed changes
Copy link
Contributor

@3pointer 3pointer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@shuijing198799 shuijing198799 requested a review from 3pointer April 20, 2020 02:35
@yikeke yikeke requested a review from TomShawn April 21, 2020 06:55
kissmydb
kissmydb reviewed Apr 21, 2020
View reviewed changes
kissmydb
kissmydb reviewed Apr 21, 2020
View reviewed changes
reference/tools/br/br.md Outdated

### 备份数据到 Amazon S3 后端存储

如果备份的存储并不是在本地，而是在 Amazon 的 S3 后端存储，那么我们需要在 `storage` 子命令中指定 S3 的存储路径，并且赋予 BR 节点和 TiKV 节点访问 Amazon S3 的权限。
Copy link
Contributor

@kissmydb kissmydb Apr 21, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我们支持的是通用 S3 接口，这里只是以 Amazon S3 为例，建议增加一句描述。同样的在恢复部分

Copy link
Contributor Author

@shuijing198799 shuijing198799 Apr 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个稳定是专指的 Amazon S3，如果是 类 Amazon S3 的接口，应该制定 endpoint 而不是 region

Copy link
Contributor

@TomShawn TomShawn May 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kissmydb PTAL

Copy link
Contributor

@kissmydb kissmydb May 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

和 @shuijing198799 沟通了下，下周增加一个通用 S3 分支的使用分支

Copy link
Contributor

@TomShawn TomShawn May 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的。
@shuijing198799 请下周另提 PR 更新这一部分，thanks~

TomShawn
TomShawn reviewed Apr 21, 2020
View reviewed changes
@TomShawn
Copy link
Contributor

TomShawn commented Apr 22, 2020

LGTM

@TomShawn TomShawn added the status/PTAL This PR is ready for reviewing. label Apr 27, 2020
@TomShawn
Copy link
Contributor

TomShawn commented Apr 27, 2020

@kissmydb PTAL again

@sre-bot
Copy link
Contributor

sre-bot commented Apr 29, 2020

@3pointer, @kissmydb, @TomShawn, PTAL.

2 similar comments
@sre-bot
Copy link
Contributor

sre-bot commented May 1, 2020

@3pointer, @kissmydb, @TomShawn, PTAL.

@sre-bot
Copy link
Contributor

sre-bot commented May 4, 2020

@3pointer, @kissmydb, @TomShawn, PTAL.

@TomShawn TomShawn added requires-followup This PR requires a follow-up task after being merged. and removed status/PTAL This PR is ready for reviewing. labels May 6, 2020
@shuijing198799
Copy link
Contributor Author

shuijing198799 commented May 6, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 6, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 6, 2020

/run-all-tests

@sre-bot sre-bot merged commit 2d463ce into pingcap:master May 6, 2020
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request May 6, 2020
@shuijing198799 @sre-bot
br: add backup and resotre from s3 with BR (pingcap#2802)
fb7f9d7
@sre-bot sre-bot mentioned this pull request May 6, 2020
Merged
5 tasks
@sre-bot
Copy link
Contributor

sre-bot commented May 6, 2020

cherry pick to release-3.1 in PR #2964

sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request May 6, 2020
@shuijing198799 @sre-bot
br: add backup and resotre from s3 with BR (pingcap#2802)
79a3e4e
@sre-bot sre-bot mentioned this pull request May 6, 2020
Merged
5 tasks
@sre-bot
Copy link
Contributor

sre-bot commented May 6, 2020

cherry pick to release-4.0 in PR #2965

TomShawn pushed a commit that referenced this pull request May 6, 2020
@sre-bot @shuijing198799
br: add backup and resotre from s3 with BR (#2802) (#2964)
5f591f2 
Co-authored-by: 尹亮 <30903849+shuijing198799@users.noreply.github.com>
TomShawn pushed a commit that referenced this pull request May 6, 2020
@sre-bot @shuijing198799
br: add backup and resotre from s3 with BR (#2802) (#2965)
c783c29 
Co-authored-by: 尹亮 <30903849+shuijing198799@users.noreply.github.com>
rleungx pushed a commit to rleungx/docs-cn that referenced this pull request May 22, 2020
@shuijing198799 @rleungx
br: add backup and resotre from s3 with BR (pingcap#2802)
48dfe17
@toutdesuite toutdesuite mentioned this pull request Jun 3, 2020
Merged
5 tasks
@toutdesuite toutdesuite added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 3, 2020
This was referenced Jun 8, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@3pointer 3pointer Awaiting requested review from 3pointer

@kissmydb kissmydb Awaiting requested review from kissmydb

1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TomShawn TomShawn

Labels

requires-followup This PR requires a follow-up task after being merged. status/can-merge Indicates a PR has been approved by a committer. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@shuijing198799 @TomShawn @sre-bot @3pointer @kissmydb @toutdesuite