Skip to content

sql: update docs for split partition table #2810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Apr 20, 2020
Merged

sql: update docs for split partition table #2810

merged 20 commits into from
Apr 20, 2020

Conversation

@crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Apr 17, 2020

Signed-off-by: crazycs520 crazycs520@gmail.com

What is changed, added or deleted? (Required)

update docs for split table statement.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@crazycs520
sql: update docs for split partition table
45f53a9 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@TomShawn TomShawn added needs-cherry-pick-4.0 translation/doing This PR’s assignee is translating this PR. labels Apr 17, 2020
@TomShawn TomShawn self-assigned this Apr 17, 2020
@TomShawn
Copy link
Contributor

TomShawn commented Apr 17, 2020

@crazycs520 Please involve a technical review.

@crazycs520
Copy link
Contributor Author

crazycs520 commented Apr 17, 2020

@tiancaiamao PTAL

crazycs520
crazycs520 commented Apr 20, 2020
View reviewed changes
tiancaiamao
tiancaiamao reviewed Apr 20, 2020
View reviewed changes
@tiancaiamao
Copy link
Contributor

tiancaiamao commented Apr 20, 2020

LGTM

@tiancaiamao tiancaiamao added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 20, 2020
@lilin90 lilin90 added the priority/P1 The issue has P1 priority. label Apr 20, 2020
lilin90
lilin90 reviewed Apr 20, 2020
View reviewed changes
crazycs520 and others added 12 commits April 20, 2020 16:36
@crazycs520 @lilin90
Update reference/sql/statements/split-region.md
2ad9014 
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
@crazycs520 @lilin90
Update reference/sql/statements/split-region.md
305b1ce 
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
@crazycs520 @lilin90
Update reference/sql/statements/split-region.md
2e4557a 
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
@crazycs520 @lilin90
Update reference/sql/statements/split-region.md
43a6f0f 
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
@crazycs520 @lilin90
Update reference/sql/statements/split-region.md
b61fa88 
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
@crazycs520 @lilin90
Update reference/sql/statements/split-region.md
018f8db 
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
@crazycs520 @lilin90
Update reference/sql/statements/split-region.md
60d29ed 
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
@crazycs520 @lilin90
Update reference/sql/statements/split-region.md
d6b4798 
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
@crazycs520 @lilin90
Update reference/sql/statements/split-region.md
e1e095b 
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
@crazycs520 @lilin90
Update reference/sql/statements/split-region.md
a2b3f66 
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
@crazycs520 @lilin90
Update reference/sql/statements/split-region.md
6dac47e 
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
@crazycs520 @lilin90
Update reference/sql/statements/split-region.md
a08bd77 
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
@TomShawn TomShawn mentioned this pull request Apr 20, 2020
Merged
5 tasks
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 20, 2020
@pingcap pingcap deleted a comment from crazycs520 Apr 20, 2020
@pingcap pingcap deleted a comment from crazycs520 Apr 20, 2020
lilin90
lilin90 approved these changes Apr 20, 2020
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 added the status/LGT2 Indicates that a PR has LGTM 2. label Apr 20, 2020
@lilin90
Copy link
Member

lilin90 commented Apr 20, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 20, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 20, 2020

/run-all-tests

@sre-bot sre-bot merged commit 45ae6f4 into pingcap:master Apr 20, 2020
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Apr 20, 2020
@crazycs520 @sre-bot
sql: update docs for split partition table (pingcap#2810)
61d9429
@sre-bot sre-bot mentioned this pull request Apr 20, 2020
Merged
5 tasks
@sre-bot
Copy link
Contributor

sre-bot commented Apr 20, 2020

cherry pick to release-4.0 in PR #2837

sre-bot added a commit that referenced this pull request Apr 20, 2020
@sre-bot
sql: update docs for split partition table (#2810) (#2837)
9bb966c
@sre-bot sre-bot mentioned this pull request Apr 20, 2020
Merged
5 tasks
rleungx pushed a commit to rleungx/docs-cn that referenced this pull request May 22, 2020
@crazycs520 @rleungx
sql: update docs for split partition table (pingcap#2810)
5fb2a64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiancaiamao tiancaiamao tiancaiamao left review comments

@lilin90 lilin90 lilin90 approved these changes

Assignees

@TomShawn TomShawn

Labels

priority/P1 The issue has P1 priority. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@crazycs520 @TomShawn @tiancaiamao @lilin90 @sre-bot