Skip to content

Conversation

@TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Apr 20, 2020

What is changed, added or deleted? (Required)

Update doc for the split table statement.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@TomShawn TomShawn added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. priority/P1 The issue has P1 priority. needs-cherry-pick-4.0 labels Apr 20, 2020
@TomShawn TomShawn requested review from crazycs520 and lilin90 April 20, 2020 08:47
@TomShawn TomShawn changed the title sql: update docs for split partition table sql: update doc for split partition table Apr 20, 2020
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

```

* `TOTAL_SPLIT_REGION`: the number of newly split Regions.
* `SCATTER_FINISH_RATIO`: the scattering rate of the newly split Regions. `1.0` means that all Regions are scattered. `0.5` means that only half of the Regions are scattered and the rest are being scattered.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* `SCATTER_FINISH_RATIO`: the scattering rate of the newly split Regions. `1.0` means that all Regions are scattered. `0.5` means that only half of the Regions are scattered and the rest are being scattered.
* `SCATTER_FINISH_RATIO`: the completion rate of scattering for newly split Regions. `1.0` means that all Regions are scattered. `0.5` means that only half of the Regions are scattered and the rest are being scattered.

@TomShawn
Copy link
Contributor Author

@lilin90 All comments are addressed, PTAL again, thanks!

lilin90 and others added 2 commits April 20, 2020 18:50
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 merged commit eb4e6fe into pingcap:master Apr 20, 2020
@lilin90 lilin90 added the status/LGT2 Indicates that a PR has LGTM 2. label Apr 20, 2020
sre-bot pushed a commit to sre-bot/docs that referenced this pull request Apr 20, 2020
* sql: update docs for split partition table

* Update split-region.md

* address comments

* address comments

Co-Authored-By: Lilian Lee <lilin@pingcap.com>

Co-authored-by: Lilian Lee <lilin@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Apr 20, 2020

cherry pick to release-4.0 in PR #2347

lilin90 added a commit that referenced this pull request Apr 20, 2020
* sql: update docs for split partition table

* Update split-region.md

* address comments

* address comments

Co-Authored-By: Lilian Lee <lilin@pingcap.com>

Co-authored-by: Lilian Lee <lilin@pingcap.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@TomShawn TomShawn deleted the update-split branch April 20, 2020 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority/P1 The issue has P1 priority. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants