Skip to content

Conversation

@yikeke
Copy link
Contributor

@yikeke yikeke commented Apr 20, 2020

What is changed, added or deleted? (Required)

  1. Update title according to the English ver
  2. Refine a description

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@yikeke yikeke requested a review from superlzs0476 April 20, 2020 08:37
@yikeke yikeke added needs-cherry-pick-4.0 translation/from-docs This PR is translated from a PR in pingcap/docs. labels Apr 20, 2020
@yikeke yikeke requested a review from ran-huang April 20, 2020 09:06
Copy link
Contributor

@superlzs0476 superlzs0476 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TOC.md Outdated
+ 操作指南
+ 快速上手
- [快速体验 TiDB 集群](/how-to/get-started/quick-start-with-tidb.md)
- [TiDB 数据库快速上手指南](/how-to/get-started/quick-start-with-tidb.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about moving it under 关于 TiDB?Just like the English doc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confirming this. Waiting on Tang Liu's reply.

@yikeke yikeke removed the status/DNM label Apr 20, 2020
Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke
Copy link
Contributor Author

yikeke commented Apr 20, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 20, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 20, 2020

Your auto merge job has been accepted, waiting for:

  • 2752

@sre-bot
Copy link
Contributor

sre-bot commented Apr 20, 2020

/run-all-tests

@sre-bot sre-bot merged commit 8483411 into master Apr 20, 2020
@yikeke yikeke deleted the update-quick-start-1 branch April 20, 2020 09:51
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Apr 20, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 20, 2020

cherry pick to release-4.0 in PR #2835

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. translation/from-docs This PR is translated from a PR in pingcap/docs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants