Skip to content

Conversation

@ran-huang
Copy link
Contributor

@ran-huang ran-huang commented Apr 17, 2020

What is changed, added or deleted? (Required)

Add the quick-start-with-tidb doc.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@ran-huang ran-huang added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-4.0 labels Apr 17, 2020
@lilin90 lilin90 requested a review from yikeke April 17, 2020 05:48
Copy link
Contributor

@superlzs0476 superlzs0476 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! I just made some small suggestions.

Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL @queenypingcap

@yikeke yikeke requested a review from QueenyJin April 19, 2020 11:12
ran-huang and others added 4 commits April 19, 2020 19:20
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
TOC.md Outdated
+ How-to
+ Get Started
+ Start a Cluster
- [Quick Start with TiDB](/how-to/get-started/quick-start-with-tidb.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This guide looks great! I would like to suggest moving this guide to be right behind the Introduction on the main TOC.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the title to be "Quick Start Guide for the TiDB Database Platform". This is to avoid the possible confusion of the TiDB server component and the entire TiDB database platform.

@ran-huang
Copy link
Contributor Author

@yikeke Comments addressed. PTAL~

@ran-huang
Copy link
Contributor Author

@queenypingcap Comments addressed. PTAL~
Also, I only changed the title in the file to Quick Start Guide for the TiDB Database Platform, but left the title in TOC as it was (Get Started with TiDB). This is because I think given the TOC context, users can hardly confuse the TiDB component with the TiDB platform, and a long title might look awkward in the left-hand navigator.

@QueenyJin
Copy link
Contributor

@queenypingcap Comments addressed. PTAL~
Also, I only changed the title in the file to Quick Start Guide for the TiDB Database Platform, but left the title in TOC as it was (Get Started with TiDB). This is because I think given the TOC context, users can hardly confuse the TiDB component with the TiDB platform, and a long title might look awkward in the left-hand navigator.

It‘s okay to keep the Title in ToC as it is.

TOC.md Outdated

+ Introduction
- [TiDB Introduction](/overview.md)
- [Quick Start with TiDB](/how-to/get-started/quick-start-with-tidb.md)
Copy link
Contributor

@yikeke yikeke Apr 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [Quick Start with TiDB](/how-to/get-started/quick-start-with-tidb.md)
- [Quick Start Guide for the TiDB Database Platform](/how-to/get-started/quick-start-with-tidb.md)

Do we need to change the file location as the ToC suggests? @queenypingcap

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please do

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the file location and the ToC link, thx~ @ran-huang

Copy link
Contributor

@QueenyJin QueenyJin Apr 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of moving it one level up to be in parallel with Introduction? It may not make sense if you think it strictly from how it should be categorized, but it is the most important information a reader wants to read.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might consider it a good trade-off. It's worth trying at least for some time. If anyone poses a challenge to the file location, we can re-discuss it with more feedback then.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. PTAL~@queenypingcap @yikeke

Copy link
Contributor

@QueenyJin QueenyJin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke
Copy link
Contributor

yikeke commented Apr 20, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 20, 2020
@yikeke yikeke removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 20, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 20, 2020

/run-all-tests

Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke merged commit 3114615 into pingcap:master Apr 20, 2020
sre-bot added a commit to sre-bot/docs that referenced this pull request Apr 20, 2020
* how-to: add quick-start-with-tidb doc

* test markdownlint

* revert the change

* Apply suggestions from coco

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* Apply suggestions from coco

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* move the notes

* address comments

* move the file location and edit toc

* fix an anchor link

Co-authored-by: Lilian Lee <lilin@pingcap.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: pingcap-github-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Apr 20, 2020

cherry pick to release-4.0 in PR #2338

yikeke added a commit that referenced this pull request Apr 20, 2020
* how-to: add quick-start-with-tidb doc

* test markdownlint

* revert the change

* Apply suggestions from coco

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* Apply suggestions from coco

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>

* move the notes

* address comments

* move the file location and edit toc

* fix an anchor link

Co-authored-by: Lilian Lee <lilin@pingcap.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: pingcap-github-bot <sre-bot@pingcap.com>

Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Lilian Lee <lilin@pingcap.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
@yikeke
Copy link
Contributor

yikeke commented Apr 20, 2020

I align @queenypingcap 's suggested changes in pingcap/docs-cn#2827. Please help check whether I missed anything. @ran-huang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants