Skip to content

Conversation

@sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 29, 2020

cherry-pick #2756 to release-4.0


What is changed, added or deleted? (Required)

Fix some changed place in SQL diagnosis-related system table documents.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

* refine sql diagnosis

* refine

* refine

* refine doc

* refine

* refine

* Update reference/system-databases/inspection-result.md

Co-Authored-By: crazycs <crazycs520@gmail.com>

* Update reference/system-databases/metrics-schema.md

Co-Authored-By: crazycs <crazycs520@gmail.com>

* Update reference/system-databases/inspection-summary.md

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* address comment

Co-authored-by: crazycs <crazycs520@gmail.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@sre-bot sre-bot mentioned this pull request Apr 29, 2020
5 tasks
@sre-bot sre-bot added status/PTAL This PR is ready for reviewing. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. type/bugfix This PR fixes a bug. labels Apr 29, 2020
@sre-bot sre-bot requested review from TomShawn and crazycs520 April 29, 2020 06:53
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn merged commit 9822438 into pingcap:release-4.0 Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/PTAL This PR is ready for reviewing. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants