reference: refine sql diagnosis #2756

reafans · 2020-04-15T06:14:15Z

What is changed, added or deleted? (Required)

Fix some changed place in SQL diagnosis-related system table documents.

Which TiDB version(s) do your changes apply to? (Required)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s): reference/system-databases: add 12 new documents for sql diagnosis #2522

…ne_sql_diagnosis

TomShawn

LGTM
@lonng @crazycs520 PTAL

TomShawn · 2020-04-21T11:14:15Z

Please update this PR according this comment.

…ne_sql_diagnosis

…s-cn into refine_sql_diagnosis

crazycs520 · 2020-04-23T07:50:55Z

reference/system-databases/cluster-hardware.md

-| tidb | 127.0.0.1:10080 | cpu         | cpu         | cpu-logical-cores  | 8     |
-| tidb | 127.0.0.1:10080 | cpu         | cpu         | cpu-physical-cores | 4     |
-| pd   | 127.0.0.1:2379  | cpu         | cpu         | cpu-logical-cores  | 8     |
+| tidb | 0.0.0.0:4000    | cpu         | cpu         | cpu-logical-cores  | 4     |


Both cpu-logical-cores and cpu-physical-cores is 4?

I run it in the Virtual Machine of the Virtual Box，so it shows that both of them are same. To avoid misunderstand, i changed it back to 8.

reference/system-databases/inspection-result.md

reference/system-databases/metrics-schema.md

Co-Authored-By: crazycs <crazycs520@gmail.com>

reference/system-databases/inspection-summary.md

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

TomShawn · 2020-04-26T08:59:02Z

reference/system-databases/inspection-result.md

 | TiKV | leader-score-balance | pd_scheduler_store_status  | 小于 0.05 | 检测各个 TiKV 节点的 leader score 是否均衡，期望节点间的差异小于 5% |
 | TiKV | region-score-balance | pd_scheduler_store_status  | 小于 0.05 | 检测各个 TiKV 节点的 Region score 是否均衡，期望节点间的差异小于 5% |
 | TiKV | store-available-balance | pd_scheduler_store_status  | 小于 0.2 | 检测各个 TiKV 节点的存储可用空间大小是否均衡，期望节点间的差异小于 20% |
 | TiKV | region-count | pd_scheduler_store_status  | 小于 20000 | 检测各个 TiKV 节点的 Region 数量，期望单个节点的 Region 数量小于 20000 |


@reafans 请再确认 SQL 诊断相关系统表文档中的 节点 是否应该替换成 实例。

TomShawn · 2020-04-26T08:59:45Z

reference/system-databases/metrics-schema.md

-* `QUANTILE`：百分位。对于直方图类型的监控数据，指定一个默认百分位。如果值为 `0`，表示该监控表对应的监控不是直方图。`tidb_query_duration` 默认查询 0.9 ，也就是 P90 的监控值。
-* `COMMENT`：对这个监控表的解释。可以看出 `tidb_query_duration` 表的是用来查询 TiDB query 执行的百分位时间，如 P999/P99/P90 的查询耗时，单位是秒。
+* `QUANTILE`：百分位。直方图类型的监控数据会指定一个默认百分位。如果值为 `0`，表示该监控表对应的监控不是直方图。`tidb_query_duration` 默认查询 0.9 ，也就是 P90 的监控值。
+* `COMMENT`：对这个监控表的解释。可以看出 `tidb_query_duration` 表是用来查询 TiDB query 执行的百分位时间的，如 P999/P99/P90 的查询耗时，单位是秒。


Suggested change

* `COMMENT`：对这个监控表的解释。可以看出 `tidb_query_duration` 表是用来查询 TiDB query 执行的百分位时间的，如 P999/P99/P90 的查询耗时，单位是秒。

* `COMMENT`：对这个监控表的解释。可以看出 `tidb_query_duration` 表是用来查询 TiDB query 执行的百分位时间，如 P999/P99/P90 的查询耗时，单位是秒。

TomShawn · 2020-04-26T09:00:28Z

reference/system-databases/sql-diagnosis.md

+* 集群日志表 [`information_schema.cluster_log`](/reference/system-databases/cluster-log.md) 用于集群日志查询，通过将查询条件下推到各个实例，降低日志查询对集群的影响，性能影响小于等 grep 命令。

-TiDB 4.0 之前的系统表，只能查看当前节点，TiDB 4.0 实现了对应的集群表，可以在单个 TiDB 节点上拥有整个集群的全局视图。这些表目前都位于 [`information_schema`](/reference/system-databases/information-schema.md) 中，查询方式与其他 `information_schema` 系统表一致。
+TiDB 4.0 之前的系统表，只能查看当前节点信息，TiDB 4.0 实现了对应的集群表，可以在单个 TiDB 实例上拥有整个集群的全局视图。这些表目前都位于 [`information_schema`](/reference/system-databases/information-schema.md) 中，查询方式与其他 `information_schema` 系统表一致。


是节点还是实例呢？

TomShawn · 2020-04-26T09:02:33Z

reference/system-databases/sql-diagnosis.md

-* 集群拓扑表 [`information_schema.cluster_info`](/reference/system-databases/cluster-info.md) 用于获取集群当前的拓扑信息，以及各个节点的版本、版本对应的 Git Hash、各节点的启动时间、各节点的运行时间。
-* 集群配置表 [`information_schema.cluster_config`](/reference/system-databases/cluster-config.md) 用于获取集群当前所有节点的配置。对于 TiDB 4.0 之前的版本，用户必须逐个访问各个节点的 HTTP API 才能获取这些配置信息。
+* 集群拓扑表 [`information_schema.cluster_info`](/reference/system-databases/cluster-info.md) 用于获取集群当前的拓扑信息，以及各个实例的版本、版本对应的 Git Hash、各实例的启动时间、各实例的运行时间。
+* 集群配置表 [`information_schema.cluster_config`](/reference/system-databases/cluster-config.md) 用于获取集群当前所有实例的配置。对于 TiDB 4.0 之前的版本，用户必须逐个访问各个节点中实例的 HTTP API 才能获取这些配置信息。


…ne_sql_diagnosis

…s-cn into refine_sql_diagnosis

TomShawn

LGTM
@crazycs520 PTAL again

crazycs520

LGTM

* refine sql diagnosis * refine * refine * refine doc * refine * refine * Update reference/system-databases/inspection-result.md Co-Authored-By: crazycs <crazycs520@gmail.com> * Update reference/system-databases/metrics-schema.md Co-Authored-By: crazycs <crazycs520@gmail.com> * Update reference/system-databases/inspection-summary.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * address comment Co-authored-by: crazycs <crazycs520@gmail.com> Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

sre-bot · 2020-04-29T06:53:11Z

cherry pick to release-4.0 in PR #2923

* refine sql diagnosis * refine * refine * refine doc * refine * refine * Update reference/system-databases/inspection-result.md Co-Authored-By: crazycs <crazycs520@gmail.com> * Update reference/system-databases/metrics-schema.md Co-Authored-By: crazycs <crazycs520@gmail.com> * Update reference/system-databases/inspection-summary.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * address comment Co-authored-by: crazycs <crazycs520@gmail.com> Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> Co-authored-by: reafans <30926443+reafans@users.noreply.github.com> Co-authored-by: crazycs <crazycs520@gmail.com> Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

* refine sql diagnosis * refine * refine * refine doc * refine * refine * Update reference/system-databases/inspection-result.md Co-Authored-By: crazycs <crazycs520@gmail.com> * Update reference/system-databases/metrics-schema.md Co-Authored-By: crazycs <crazycs520@gmail.com> * Update reference/system-databases/inspection-summary.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * address comment Co-authored-by: crazycs <crazycs520@gmail.com> Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

reafans added 2 commits April 15, 2020 12:23

refine sql diagnosis

4657403

Merge branch 'master' of https://github.com/pingcap/docs-cn into refi…

9ce307b

…ne_sql_diagnosis

reafans added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/bugfix This PR fixes a bug. needs-cherry-pick-4.0 labels Apr 15, 2020

reafans added 2 commits April 15, 2020 15:16

refine

7d35446

Merge branch 'master' of https://github.com/pingcap/docs-cn into refi…

fdce53e

…ne_sql_diagnosis

reafans requested a review from TomShawn April 15, 2020 07:24

TomShawn reviewed Apr 15, 2020

View reviewed changes

TomShawn self-assigned this Apr 15, 2020

refine

a267006

TomShawn added translation/doing This PR’s assignee is translating this PR. and removed translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. labels Apr 15, 2020

Merge branch 'master' into refine_sql_diagnosis

cb50933

reafans and others added 6 commits April 22, 2020 11:03

Merge branch 'master' of https://github.com/pingcap/docs-cn into refi…

2251c3b

…ne_sql_diagnosis

Merge branch 'refine_sql_diagnosis' of https://github.com/reafans/doc…

1ec9d5c

…s-cn into refine_sql_diagnosis

refine doc

74429d2

refine

104710c

refine

f35d8ae

Merge branch 'master' into refine_sql_diagnosis

a873b08

crazycs520 reviewed Apr 23, 2020

View reviewed changes

reference/system-databases/inspection-result.md Outdated Show resolved Hide resolved

crazycs520 reviewed Apr 23, 2020

View reviewed changes

reference/system-databases/metrics-schema.md Outdated Show resolved Hide resolved

reafans and others added 2 commits April 23, 2020 16:01

Update reference/system-databases/inspection-result.md

310d278

Co-Authored-By: crazycs <crazycs520@gmail.com>

Update reference/system-databases/metrics-schema.md

d71fb72

Co-Authored-By: crazycs <crazycs520@gmail.com>

TomShawn reviewed Apr 23, 2020

View reviewed changes

reference/system-databases/inspection-summary.md Outdated Show resolved Hide resolved

Update reference/system-databases/inspection-summary.md

b9989be

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

TomShawn reviewed Apr 26, 2020

View reviewed changes

TomShawn added the status/require-change Needs the author to address comments. label Apr 27, 2020

reafans added 3 commits April 28, 2020 10:50

Merge branch 'master' of https://github.com/pingcap/docs-cn into refi…

4960516

…ne_sql_diagnosis

address comment

77b1db9

Merge branch 'refine_sql_diagnosis' of https://github.com/reafans/doc…

252242e

…s-cn into refine_sql_diagnosis

TomShawn approved these changes Apr 28, 2020

View reviewed changes

TomShawn added status/PTAL This PR is ready for reviewing. and removed status/require-change Needs the author to address comments. labels Apr 28, 2020

crazycs520 reviewed Apr 29, 2020

View reviewed changes

Merge branch 'master' into refine_sql_diagnosis

eb0bdc6

reafans merged commit 3b429fc into pingcap:master Apr 29, 2020

reafans deleted the refine_sql_diagnosis branch April 29, 2020 06:52

sre-bot mentioned this pull request Apr 29, 2020

reference: refine sql diagnosis. (#2756) #2923

Merged

5 tasks

TomShawn changed the title ~~reference: refine sql diagnosis.~~ reference: refine sql diagnosis Apr 29, 2020

TomShawn mentioned this pull request Apr 29, 2020

reference: refine sql diagnosis pingcap/docs#2430

Merged

5 tasks

TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 29, 2020

sre-bot mentioned this pull request May 8, 2020

reference: refine sql diagnosis (#2430) pingcap/docs#2493

Merged

5 tasks

	* `COMMENT`：对这个监控表的解释。可以看出 `tidb_query_duration` 表是用来查询 TiDB query 执行的百分位时间的，如 P999/P99/P90 的查询耗时，单位是秒。
	* `COMMENT`：对这个监控表的解释。可以看出 `tidb_query_duration` 表是用来查询 TiDB query 执行的百分位时间，如 P999/P99/P90 的查询耗时，单位是秒。

reference: refine sql diagnosis #2756

reference: refine sql diagnosis #2756

Uh oh!

Conversation

reafans commented Apr 15, 2020

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Uh oh!

TomShawn left a comment

Choose a reason for hiding this comment

Uh oh!

TomShawn commented Apr 21, 2020

Uh oh!

crazycs520 Apr 23, 2020

Choose a reason for hiding this comment

Uh oh!

reafans Apr 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TomShawn Apr 26, 2020

Choose a reason for hiding this comment

Uh oh!

TomShawn Apr 26, 2020

Choose a reason for hiding this comment

Uh oh!

TomShawn Apr 26, 2020

Choose a reason for hiding this comment

Uh oh!

TomShawn Apr 26, 2020

Choose a reason for hiding this comment

Uh oh!

TomShawn left a comment

Choose a reason for hiding this comment

Uh oh!

crazycs520 left a comment

Choose a reason for hiding this comment

Uh oh!

sre-bot commented Apr 29, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

reafans Apr 23, 2020 •

edited

Loading