Skip to content

Conversation

@Deardrops
Copy link
Contributor

What is changed, added or deleted? (Required)

Now we implement new feature invisible index in TiDB, we introduce it in docs and update some docs related to it.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

- 不支持 `VISIBLE/INVISIBLE` 的索引
- 其他类型的 Index Type (HASH/BTREE/RTREE) 只有语法支持,功能不支持
+ Add Column
- 不支持同时创建多个列
Copy link
Contributor Author

@Deardrops Deardrops May 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature has implemented in TiDB, this line should be removed.

ERROR 3522 (HY000): A primary key index cannot be invisible
```

这里的**主键**包括隐式的主键,隐式主键指的是当表中不存在显式的主键时,第一个 UNIQUE 索引(要求满足索引上的每一列都是 NOT NULL)会成为隐式的主键。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please describe that implict PK doesnt exist in tidb actaully, but we treat it exists so that invisible index behaves the same with mysql

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bb7133 addressed

@TomShawn TomShawn self-requested a review May 9, 2020 06:58
@TomShawn TomShawn self-assigned this May 9, 2020
@TomShawn
Copy link
Contributor

TomShawn commented May 9, 2020

@Deardrops Does this PR apply to v4.0?

@TomShawn TomShawn added size/large Changes of a large size. status/require-change Needs the author to address comments. translation/doing This PR’s assignee is translating this PR. labels May 9, 2020
@Deardrops
Copy link
Contributor Author

Deardrops commented May 9, 2020

@Deardrops Does this PR apply to v4.0?

@TomShawn This PR only apply to dev, do not need to apply to any release branch.

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job!

@bb7133 bb7133 added status/LGT1 Indicates that a PR has LGTM 1. and removed status/require-change Needs the author to address comments. labels May 9, 2020
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

@Deardrops
Copy link
Contributor Author

@AilinKid Addressed, PTAL

Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Deardrops Deardrops added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 11, 2020
@Deardrops
Copy link
Contributor Author

@TomShawn this PR has LGT2, PTAL

@AilinKid
Copy link
Contributor

@TomShawn PTAL

Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn merged commit 34c7389 into pingcap:master May 11, 2020
rleungx pushed a commit to rleungx/docs-cn that referenced this pull request May 22, 2020
* sql: introduce invisible index

* address comment

* address comment

* refine format

Co-authored-by: Arenatlx <ailinsilence4@gmail.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn TomShawn added the requires-followup This PR requires a follow-up task after being merged. label May 22, 2020
@TomShawn TomShawn added the v5.0 This PR/issue applies to TiDB v5.0 label May 22, 2020
@TomShawn
Copy link
Contributor

I'll add this document in TOC after this week.

@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 19, 2020
@TomShawn TomShawn removed the requires-followup This PR requires a follow-up task after being merged. label Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/large Changes of a large size. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v5.0 This PR/issue applies to TiDB v5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants