Skip to content

sql-statements: update some statements #2924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 19, 2020
Merged

sql-statements: update some statements #2924

merged 3 commits into from
Jun 19, 2020

Conversation

@zimulala
Copy link
Contributor

@zimulala zimulala commented Jun 17, 2020 •
edited by yikeke
Loading

What is changed, added or deleted? (Required)

Update the docs for some statements, such as change column, create database, drop column, drop table, rename index. And some statements with "alter" prefixed statements.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@yikeke yikeke requested review from bb7133 and yikeke June 17, 2020 05:33
@yikeke yikeke added needs-cherry-pick-4.0 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jun 17, 2020
yikeke
yikeke approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@yikeke
Copy link
Contributor

yikeke commented Jun 18, 2020

sql-statements/sql-statement-alter-index.md is not aligned in this PR. Do you know which PR updates https://github.com/pingcap/docs-cn/pull/3235/files#diff-c4db67744480812d582d8e0c8344c2cbR12 in docs repo? @zimulala

@yikeke yikeke added the status/require-change Needs the author to address comments. label Jun 18, 2020
@zimulala
Copy link
Contributor Author

zimulala commented Jun 19, 2020

@yikeke
Now we haven't the file of sql-statements/sql-statement-alter-index.md.

@yikeke
Copy link
Contributor

yikeke commented Jun 19, 2020

sql-statements/sql-statement-alter-index.md

Got it. I found that pingcap/docs-cn#3011 has not been aligned in docs right now. Will find someone to update sql-statements/sql-statement-alter-index.md ASAP, thanks~

yikeke
yikeke approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke
Copy link
Contributor

yikeke commented Jun 19, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 19, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 19, 2020

/run-all-tests

@zimulala zimulala merged commit b3edda2 into pingcap:master Jun 19, 2020
@zimulala zimulala deleted the some-sqls branch June 19, 2020 03:22
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jun 19, 2020
@zimulala @ti-srebot
cherry pick pingcap#2924 to release-4.0
7ebdb66 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 19, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 19, 2020

cherry pick to release-4.0 in PR #2965

yikeke pushed a commit that referenced this pull request Jun 19, 2020
@ti-srebot @zimulala
cherry pick #2924 to release-4.0 (#2965)
98788c4 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Lynn <zimu_xia@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bb7133 bb7133 Awaiting requested review from bb7133

1 more reviewer

@yikeke yikeke yikeke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status/can-merge Indicates a PR has been approved by a committer. status/require-change Needs the author to address comments. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zimulala @yikeke @ti-srebot