-
Notifications
You must be signed in to change notification settings - Fork 1.2k
add require SAN to certificate authentication docs
#3429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomShawn
reviewed
Jun 1, 2020
jackysp
reviewed
Jun 1, 2020
Member
jackysp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn
approved these changes
Jun 1, 2020
Contributor
TomShawn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Contributor
|
/merge |
Contributor
|
/run-all-tests |
Contributor
|
/run-cherry-picker |
5 tasks
sre-bot
pushed a commit
to sre-bot/docs-cn
that referenced
this pull request
Jun 2, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
Contributor
|
cherry pick to release-4.0 in PR #3441 |
sre-bot
added a commit
that referenced
this pull request
Jun 2, 2020
5 tasks
yikeke
pushed a commit
to pingcap/docs
that referenced
this pull request
Jun 19, 2020
ti-srebot
added a commit
to pingcap/docs
that referenced
this pull request
Jun 22, 2020
* Update certificate-authentication.md * Update certificate-authentication.md * align pingcap/docs-cn#3429 * Apply suggestions from code review Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> Co-authored-by: ti-srebot <66930949+ti-srebot@users.noreply.github.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
status/can-merge
Indicates a PR has been approved by a committer.
translation/done
This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
add
require SANclause’s document to certificate authenticationWhich TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
pingcap/tidb#14759
pingcap/tidb#17539
This change is