Skip to content

Conversation

@lysu
Copy link
Contributor

@lysu lysu commented Jun 1, 2020

What is changed, added or deleted? (Required)

add require SAN clause’s document to certificate authentication

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

pingcap/tidb#14759
pingcap/tidb#17539


This change is Reviewable

@lysu lysu added the translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. label Jun 1, 2020
@TomShawn TomShawn requested review from TomShawn and jackysp June 1, 2020 09:04
@TomShawn TomShawn added the translation/doing This PR’s assignee is translating this PR. label Jun 1, 2020
@TomShawn TomShawn self-assigned this Jun 1, 2020
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lysu and others added 3 commits June 1, 2020 17:26
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn
Copy link
Contributor

TomShawn commented Jun 1, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 1, 2020
@TomShawn TomShawn removed the translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. label Jun 1, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jun 1, 2020

/run-all-tests

@sre-bot sre-bot merged commit 757eb65 into pingcap:master Jun 1, 2020
@yikeke
Copy link
Contributor

yikeke commented Jun 2, 2020

/run-cherry-picker

sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Jun 2, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jun 2, 2020

cherry pick to release-4.0 in PR #3441

@yikeke yikeke added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 19, 2020
@yikeke yikeke assigned yikeke and unassigned TomShawn Jun 19, 2020
yikeke pushed a commit to pingcap/docs that referenced this pull request Jun 19, 2020
ti-srebot added a commit to pingcap/docs that referenced this pull request Jun 22, 2020
* Update certificate-authentication.md

* Update certificate-authentication.md

* align pingcap/docs-cn#3429

* Apply suggestions from code review

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: ti-srebot <66930949+ti-srebot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants