Skip to content

certificate-authentication.md: refine cert based authentication #2973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 22, 2020
Merged

certificate-authentication.md: refine cert based authentication #2973

merged 5 commits into from
Jun 22, 2020

Conversation

@yikeke
Copy link
Contributor

@yikeke yikeke commented Jun 19, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@yikeke yikeke requested a review from lysu June 19, 2020 10:04
@github-actions github-actions bot added translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. status/PTAL This PR is ready for reviewing. labels Jun 19, 2020
@yikeke yikeke requested review from TomShawn and lysu and removed request for lysu June 19, 2020 10:04
@yikeke yikeke added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-4.0 and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jun 19, 2020
@TomShawn
Copy link
Contributor

TomShawn commented Jun 19, 2020

LGTM
@lysu PTAL

@yikeke yikeke marked this pull request as draft June 19, 2020 10:12
@yikeke yikeke marked this pull request as ready for review June 19, 2020 10:38
@yikeke
Copy link
Contributor Author

yikeke commented Jun 19, 2020

I aligned another doc, PTAL again @TomShawn @lysu

TomShawn
TomShawn reviewed Jun 19, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 21, 2020

@TomShawn, @lysu, PTAL.

lysu
lysu approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke @TomShawn
Apply suggestions from code review
bd7c22b 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@yikeke
Copy link
Contributor Author

yikeke commented Jun 22, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 22, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 22, 2020

/run-all-tests

@ti-srebot ti-srebot merged commit 7992f06 into master Jun 22, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jun 22, 2020
@yikeke @ti-srebot
cherry pick pingcap#2973 to release-4.0
07e637a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 22, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 22, 2020

cherry pick to release-4.0 in PR #2987

ti-srebot added a commit that referenced this pull request Jun 22, 2020
@ti-srebot
certificate-authentication.md: refine cert based authentication (#2973)…
beaf840 
… (#2987)

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@DanielZhangQD DanielZhangQD mentioned this pull request Jul 28, 2020
Open
@lilin90 lilin90 deleted the yikeke-patch-3 branch August 5, 2020 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@TomShawn TomShawn TomShawn left review comments

@lysu lysu lysu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status/can-merge Indicates a PR has been approved by a committer. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yikeke @TomShawn @ti-srebot @lysu