Skip to content

Conversation

@kissmydb
Copy link
Contributor

@kissmydb kissmydb commented Jun 3, 2020

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@yikeke yikeke added needs-cherry-pick-4.0 translation/doing This PR’s assignee is translating this PR. labels Jun 3, 2020
@yikeke yikeke requested a review from ran-huang June 3, 2020 12:06
```

更多方式可参考[验证集群运行状态](/post-installation-check.md)。
对于监控系统、dashboard,以及更多验证方式可参考[验证集群运行状态](/post-installation-check.md)。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
对于监控系统、dashboard,以及更多验证方式可参考[验证集群运行状态](/post-installation-check.md)
通过监控系统、TiDB Dashboard 以及更多方式来验证集群运行状态,可参考[验证集群运行状态](/post-installation-check.md)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不是这个含义,我再改一下

@yikeke yikeke requested review from superlzs0476 and removed request for ran-huang June 4, 2020 03:15
> 无需手动创建配置文件中的 `tidb` 用户,TiUP cluster 组件会在部署主机上自动创建该用户。可以自定义用户,也可以和中控机的用户保持一致。
> - 无需手动创建配置文件中的 `tidb` 用户,TiUP cluster 组件会在部署主机上自动创建该用户。可以自定义用户,也可以和中控机的用户保持一致。
> - 如果部署目录配置为相对路径,会部署在用户家目录下。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

To fix lint

kissmydb and others added 6 commits June 4, 2020 13:18
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke
Copy link
Contributor

yikeke commented Jun 4, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 4, 2020
@yikeke yikeke self-assigned this Jun 4, 2020
@yikeke yikeke merged commit 355d064 into master Jun 4, 2020
@yikeke yikeke deleted the kissmydb-patch-1 branch June 4, 2020 07:02
@sre-bot
Copy link
Contributor

sre-bot commented Jun 4, 2020

/run-all-tests

sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Jun 4, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot mentioned this pull request Jun 4, 2020
5 tasks
@sre-bot
Copy link
Contributor

sre-bot commented Jun 4, 2020

cherry pick to release-4.0 in PR #3490

sre-bot added a commit that referenced this pull request Jun 4, 2020
yikeke added a commit to pingcap/docs that referenced this pull request Jun 5, 2020
* how-to: update doc for deploying tidb cluster using tiup

* update tiup repo link

* align part of pingcap/docs-cn#3417

* translate part of pingcap/docs-cn#3476

* fix heading levels

* fix punctuation

* rename

Co-authored-by: yikeke <yikeke@pingcap.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
@yikeke yikeke added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants