Skip to content

comment-syntax: add TiDB-specific comment syntax #3477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 7, 2020
Merged

comment-syntax: add TiDB-specific comment syntax #3477

merged 2 commits into from
Jul 7, 2020

Conversation

@tangenta
Copy link
Contributor

@tangenta tangenta commented Jun 3, 2020

What is changed, added or deleted? (Required)

  • Correct the description of MySQL-specific comments.
  • Explain TiDB-specific comments like /*T! xxx */.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@TomShawn TomShawn self-assigned this Jun 7, 2020
@TomShawn TomShawn added needs-cherry-pick-3.1 translation/doing This PR’s assignee is translating this PR. labels Jun 7, 2020
@TomShawn
Copy link
Contributor

TomShawn commented Jun 7, 2020

@tangenta Please involve a technical review.

@tangenta tangenta requested a review from bb7133 June 7, 2020 12:00
bb7133
bb7133 reviewed Jul 7, 2020
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 7, 2020

@bb7133, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:docs(slack).

@bb7133
Copy link
Member

bb7133 commented Jul 7, 2020

PTAL @TomShawn , thanks!

TomShawn
TomShawn approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 7, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 7, 2020

@TomShawn,Thanks for your review.

@TomShawn TomShawn added the status/can-merge Indicates a PR has been approved by a committer. label Jul 7, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 7, 2020

/run-all-tests

@ti-srebot ti-srebot merged commit abdaf90 into pingcap:master Jul 7, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 7, 2020
@ti-srebot
cherry pick pingcap#3477 to release-3.1
9d97104 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 7, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 7, 2020

cherry pick to release-3.1 in PR #3910

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 7, 2020
@ti-srebot
cherry pick pingcap#3477 to release-4.0
f7f4747 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 7, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 7, 2020

cherry pick to release-4.0 in PR #3911

TomShawn pushed a commit that referenced this pull request Jul 7, 2020
@ti-srebot @tangenta
cherry pick #3477 to release-3.1 (#3910)
b54588d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: tangenta <tangenta@126.com>
@yikeke yikeke added the size/small Changes of a small size. label Jul 7, 2020
@yikeke yikeke assigned ireneontheway and unassigned TomShawn Jul 7, 2020
TomShawn pushed a commit that referenced this pull request Jul 7, 2020
@ti-srebot @tangenta
cherry pick #3477 to release-4.0 (#3911)
f9a2347 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: tangenta <tangenta@126.com>
@ireneontheway ireneontheway mentioned this pull request Jul 10, 2020
Merged
5 tasks
@yikeke yikeke added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 10, 2020
This was referenced Jul 13, 2020
Merged
Merged
Merged
@jiaqizho jiaqizho mentioned this pull request Dec 22, 2021
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bb7133 bb7133 bb7133 left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ireneontheway ireneontheway

Labels

size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tangenta @TomShawn @ti-srebot @bb7133 @yikeke @ireneontheway