-
Notifications
You must be signed in to change notification settings - Fork 709
comment-syntax: add TiDB-specific comment syntax (#3238) #3249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
comment-syntax: add TiDB-specific comment syntax (#3238) #3249
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
comment-syntax.md
Outdated
| SELECT STRAIGHT_JOIN col1 FROM table1,table2 WHERE ... | ||
| ``` | ||
|
|
||
| <<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the conflicts. @ireneontheway
comment-syntax.md
Outdated
| * `/*T! Specific code */`: This syntax can only be parsed and executed by TiDB, and be ignored in other databases. | ||
| * `/*T![feature_id] Specific code */`: This syntax is used to ensure compatibility between different versions of TiDB. TiDB can parse the SQL fragment in this comment only if it implements the corresponding feature of `feature_id` in the current version. For example, as the `AUTO_RANDOM` feature is introduced in v3.1.1, this version of TiDB can parse `/*T![auto_rand] auto_random */` into `auto_random`. Because the `AUTO_RANDOM` feature is not implemented in v3.0.0, the SQL statement fragment above is ignored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove changes from https://github.com/pingcap/docs-cn/pull/3477/files to align the English doc https://docs.pingcap.com/zh/tidb/v3.0/comment-syntax. @ireneontheway
remove changes from https://github.com/pingcap/docs-cn/pull/3477/files
|
LGTM @yikeke |
yikeke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
cherry-pick #3238 to release-3.0
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?