Skip to content

Conversation

@Connor1996
Copy link
Member

@Connor1996 Connor1996 commented Jun 9, 2020

What is changed, added or deleted? (Required)

Add missing tikv docs to TOC.md

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

No
aligned in pingcap/docs#2749

Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@TomShawn TomShawn requested review from kissmydb and yikeke June 9, 2020 06:48
@yikeke
Copy link
Contributor

yikeke commented Jun 9, 2020

Please fix the deadlink reported by CI. @Connor1996

@yikeke yikeke added the translation/doing This PR’s assignee is translating this PR. label Jun 9, 2020
@yikeke yikeke self-assigned this Jun 9, 2020
Copy link
Contributor

@kissmydb kissmydb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke requested a review from lilin90 June 9, 2020 08:28
Comment on lines +86 to +87
+ [TiDB 集群常见问题](/troubleshoot-tidb-cluster.md)
+ [TiDB 集群问题导图](/tidb-troubleshooting-map.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 这俩都是诊断 TiDB 集群的问题,topic 感觉类似?能不能合为一篇呢? @Connor1996
  2. 建议放到「故障诊断」下的最前面

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kissmydb @lilin90 觉得呢

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kissmydb 确认了,建了个 issue 做后续优化:Reorganize FAQ and troubleshoot related docs · Issue #3576 · pingcap/docs-cn,现在先合了

@yikeke yikeke added needs-cherry-pick-4.0 status/require-change Needs the author to address comments. labels Jun 9, 2020
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 merged commit 876cd6d into pingcap:master Jun 9, 2020
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Jun 9, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jun 9, 2020

cherry pick to release-4.0 in PR #3578

sre-bot added a commit that referenced this pull request Jun 10, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>

Co-authored-by: Connor <zbk602423539@gmail.com>
@yikeke yikeke added the size/small Changes of a small size. label Jun 19, 2020
@yikeke yikeke assigned TomShawn and unassigned yikeke Jul 28, 2020
@TomShawn TomShawn added translation/no-need No need to translate this PR. and removed translation/doing This PR’s assignee is translating this PR. labels Sep 18, 2020
@TomShawn TomShawn removed their assignment Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/small Changes of a small size. status/require-change Needs the author to address comments. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants