Skip to content

*: Update TOC.md and fix some deadlink issues #2749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jun 11, 2020
Merged

*: Update TOC.md and fix some deadlink issues #2749

merged 20 commits into from
Jun 11, 2020

Conversation

@yikeke
Copy link
Contributor

@yikeke yikeke commented Jun 9, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

yikeke
yikeke commented Jun 9, 2020
View reviewed changes
@yikeke yikeke marked this pull request as ready for review June 9, 2020 11:42
@yikeke yikeke changed the title Update TOC.md [WIP] Update TOC.md Jun 9, 2020
@yikeke yikeke requested a review from lilin90 June 9, 2020 11:43
@yikeke yikeke added needs-cherry-pick-4.0 translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. labels Jun 9, 2020
@zanmato1984 zanmato1984 mentioned this pull request Jun 10, 2020
Merged
5 tasks
@Connor1996 Connor1996 mentioned this pull request Jun 10, 2020
Merged
5 tasks
yikeke
yikeke commented Jun 10, 2020
View reviewed changes
lilin90
lilin90 reviewed Jun 10, 2020
View reviewed changes
@yikeke @lilin90
Update TOC.md
bda87a9 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
lilin90
lilin90 approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke mentioned this pull request Jun 11, 2020
Merged
5 tasks
@yikeke yikeke changed the title [WIP] Update TOC.md *: Update TOC.md and fix some deadlink issues Jun 11, 2020
@yikeke yikeke merged commit ac33565 into pingcap:master Jun 11, 2020
@yikeke yikeke added the requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. label Jun 11, 2020
@yikeke yikeke deleted the update-TOC-by-SW branch June 11, 2020 04:54
sre-bot pushed a commit to sre-bot/docs that referenced this pull request Jun 11, 2020
@yikeke @sre-bot
cherry pick pingcap#2749 to release-4.0
a04a169 
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot mentioned this pull request Jun 11, 2020
Merged
5 tasks
@sre-bot
Copy link
Contributor

sre-bot commented Jun 11, 2020

cherry pick to release-4.0 in PR #2783

yikeke added a commit that referenced this pull request Jun 11, 2020
@sre-bot @yikeke
*: Update TOC.md and fix some deadlink issues (#2749) (#2783)
d8ef678 
* cherry pick #2749 to release-4.0

Signed-off-by: sre-bot <sre-bot@pingcap.com>

* delete 3 files

* resolve conflict

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: yikeke <yikeke@pingcap.com>
@yikeke yikeke mentioned this pull request Jun 11, 2020
Merged
5 tasks
@sre-bot sre-bot mentioned this pull request Jun 11, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lilin90 lilin90 lilin90 approved these changes

+1 more reviewer

@TomShawn TomShawn TomShawn left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yikeke @sre-bot @lilin90 @TomShawn