Skip to content

Update tiflash-configuration.md #3599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 15, 2020
Merged

Update tiflash-configuration.md #3599

merged 4 commits into from
Jun 15, 2020

Conversation

@flowbehappy
Copy link
Contributor

@flowbehappy flowbehappy commented Jun 11, 2020

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@flowbehappy flowbehappy requested review from ilovesoup and zanmato1984 and removed request for ilovesoup June 11, 2020 04:06
zanmato1984
zanmato1984 reviewed Jun 11, 2020
View reviewed changes
zanmato1984
zanmato1984 approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TomShawn
TomShawn reviewed Jun 15, 2020
View reviewed changes
TomShawn
TomShawn reviewed Jun 15, 2020
View reviewed changes
TomShawn
TomShawn approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn added needs-cherry-pick-4.0 translation/doing This PR’s assignee is translating this PR. labels Jun 15, 2020
@TomShawn
Copy link
Contributor

TomShawn commented Jun 15, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 15, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jun 15, 2020

/run-all-tests

@sre-bot sre-bot merged commit 84d73bc into master Jun 15, 2020
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Jun 15, 2020
@flowbehappy @sre-bot
cherry pick pingcap#3599 to release-4.0
9af00fb 
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot mentioned this pull request Jun 15, 2020
Merged
5 tasks
@sre-bot
Copy link
Contributor

sre-bot commented Jun 15, 2020

cherry pick to release-4.0 in PR #3641

@yikeke yikeke deleted the flowbehappy-patch-2-1 branch June 15, 2020 02:38
sre-bot added a commit that referenced this pull request Jun 15, 2020
@sre-bot @flowbehappy
Update tiflash-configuration.md (#3599) (#3641)
40db8d6 
Signed-off-by: sre-bot <sre-bot@pingcap.com>

Co-authored-by: Flowyi <flowbehappy@gmail.com>
@yikeke yikeke assigned yikeke and unassigned ran-huang Jun 16, 2020
@yikeke yikeke added size/small Changes of a small size. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 19, 2020
@yikeke yikeke mentioned this pull request Jun 23, 2020
Merged
5 tasks
@ti-srebot ti-srebot mentioned this pull request Jun 28, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanmato1984 zanmato1984 zanmato1984 approved these changes

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yikeke yikeke

Labels

size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@flowbehappy @TomShawn @sre-bot @zanmato1984 @yikeke @ran-huang