Skip to content

system_tables: add column description for several information_schema tables #3617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 16, 2020
Merged

system_tables: add column description for several information_schema tables #3617

merged 2 commits into from
Jun 16, 2020

Conversation

@bb7133
Copy link
Member

@bb7133 bb7133 commented Jun 12, 2020

What is changed, added or deleted? (Required)

Add column description for several information_schema tables:

  • COLLATIONS
  • COLLATION_CHARACTER_SET_APPLICABILITY
  • CHARACTER_SETS

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@yikeke yikeke requested a review from ran-huang June 12, 2020 08:39
@yikeke yikeke added needs-cherry-pick-4.0 status/PTAL This PR is ready for reviewing. translation/doing This PR’s assignee is translating this PR. labels Jun 12, 2020
ran-huang
ran-huang approved these changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ran-huang
Copy link
Contributor

ran-huang commented Jun 12, 2020

@bb7133 Please involve a tech reviewer. Thanks~

@sre-bot
Copy link
Contributor

sre-bot commented Jun 14, 2020

@ran-huang, PTAL.

@ran-huang ran-huang requested a review from zimulala June 15, 2020 02:52
zimulala
zimulala reviewed Jun 16, 2020
View reviewed changes
system-tables/system-table-information-schema.md Outdated
`COLLATION` 表中列的含义如下：

* `COLLATION_NAME`：排序规则名称
* `COLLATION_NAME`：排序规则所属的字符集名称
Copy link
Contributor

@zimulala zimulala Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHARACTER_SET_NAME?

Copy link
Member Author

@bb7133 bb7133 Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed, thanks!

@bb7133 bb7133 force-pushed the bb7133/add_infor_desc branch from bc15082 to 2a83674 Compare June 16, 2020 06:36
zimulala
zimulala approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ran-huang ran-huang merged commit 59c6cc4 into pingcap:master Jun 16, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jun 16, 2020
@bb7133 @ti-srebot
cherry pick pingcap#3617 to release-4.0
4ed3184 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 16, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 16, 2020

cherry pick to release-4.0 in PR #3677

ti-srebot added a commit that referenced this pull request Jun 16, 2020
@ti-srebot @bb7133
system_tables: add column description for several information_schema …
f5a23c8 
…tables (#3617) (#3677)

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: bb7133 <bb7133@gmail.com>
@yikeke yikeke added the size/small Changes of a small size. label Jun 19, 2020
@ran-huang ran-huang mentioned this pull request Jul 17, 2020
Merged
5 tasks
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 17, 2020
@ti-srebot ti-srebot mentioned this pull request Jul 21, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zimulala zimulala zimulala approved these changes

+1 more reviewer

@ran-huang ran-huang ran-huang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ran-huang ran-huang

Labels

size/small Changes of a small size. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bb7133 @ran-huang @sre-bot @ti-srebot @zimulala @yikeke