-
Notifications
You must be signed in to change notification settings - Fork 709
system_tables: add column description for several tables #3322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| * `CREATE_TIME`: The time at which the table is created. | ||
| * `UPDATE_TIME`: The time at which the table is updated. | ||
| * `CHECK_TIME`: The time at which the table is checked. | ||
| * `TABLE_COLLATION`: The collation of strings in the table. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed with the author on the translation of TABLE_COLLATION
Signed-off-by: Ran <huangran@pingcap.com>
Signed-off-by: Ran <huangran@pingcap.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Signed-off-by: Ran <huangran@pingcap.com>
|
@TomShawn PTAL again. Thanks 🙏 |
TomShawn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #3358 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: Ran <huangran@pingcap.com>
| +----------------+--------------------+ | ||
| | COLLATION_NAME | CHARACTER_SET_NAME | | ||
| | utf8mb4_bin | utf8mb4 | | ||
| +----------------+--------------------+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lines 42 to 45 are duplicate with lines 34 to 38. Removed duplicates in 5202185. (also for the Chinese version)
What is changed, added or deleted? (Required)
Add column description for several information_schema tables:
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?