Skip to content

Conversation

@ran-huang
Copy link
Contributor

@ran-huang ran-huang commented Jul 17, 2020

What is changed, added or deleted? (Required)

Add column description for several information_schema tables:

  • COLLATIONS
  • COLLATION_CHARACTER_SET_APPLICABILITY
  • CHARACTER_SETS
  • SESSION_VARIABLES
  • TABLES
  • TIDB_HOT_REGIONS

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@ran-huang ran-huang requested review from TomShawn and bb7133 July 17, 2020 09:20
@ran-huang ran-huang added needs-cherry-pick-4.0 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. size/small Changes of a small size. labels Jul 17, 2020
@ran-huang ran-huang removed request for TomShawn and bb7133 July 17, 2020 09:24
@ran-huang ran-huang marked this pull request as draft July 17, 2020 09:24
@ran-huang ran-huang marked this pull request as ready for review July 17, 2020 10:24
@ran-huang ran-huang added size/medium Changes of a medium size. and removed size/small Changes of a small size. labels Jul 17, 2020
* `CREATE_TIME`: The time at which the table is created.
* `UPDATE_TIME`: The time at which the table is updated.
* `CHECK_TIME`: The time at which the table is checked.
* `TABLE_COLLATION`: The collation of strings in the table.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed with the author on the translation of TABLE_COLLATION

@TomShawn
Copy link
Contributor

LGTM
@AilinKid @bb7133 PTAL

ran-huang and others added 6 commits July 21, 2020 15:43
Signed-off-by: Ran <huangran@pingcap.com>
Signed-off-by: Ran <huangran@pingcap.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Signed-off-by: Ran <huangran@pingcap.com>
@ran-huang
Copy link
Contributor Author

@TomShawn PTAL again. Thanks 🙏

Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 21, 2020
@TomShawn TomShawn merged commit f74966f into pingcap:master Jul 21, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 21, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3358

ran-huang added a commit that referenced this pull request Jul 21, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Ran <huangran@pingcap.com>
@ran-huang ran-huang deleted the sys_table_description branch July 30, 2020 06:13
Comment on lines +42 to +45
+----------------+--------------------+
| COLLATION_NAME | CHARACTER_SET_NAME |
| utf8mb4_bin | utf8mb4 |
+----------------+--------------------+
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lines 42 to 45 are duplicate with lines 34 to 38. Removed duplicates in 5202185. (also for the Chinese version)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/medium Changes of a medium size. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants