Skip to content

br: fix an expression that isn't accurate enough #3656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 23, 2020
Merged

br: fix an expression that isn't accurate enough #3656

merged 4 commits into from
Jun 23, 2020

Conversation

@YuJuncen
Copy link
Contributor

@YuJuncen YuJuncen commented Jun 15, 2020

What is changed, added or deleted? (Required)

更改了 BR 增量备份中关于 GC 不够精确的一处描述。
见 #3654 。

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@YuJuncen YuJuncen mentioned this pull request Jun 15, 2020
Closed
@TomShawn TomShawn requested review from 3pointer and TomShawn June 15, 2020 09:55
@TomShawn TomShawn added needs-cherry-pick-3.1 translation/doing This PR’s assignee is translating this PR. labels Jun 15, 2020
@TomShawn TomShawn requested a review from BusyJay June 23, 2020 04:50
TomShawn
TomShawn approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn added the status/can-merge Indicates a PR has been approved by a committer. label Jun 23, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 23, 2020

/run-all-tests

@ti-srebot ti-srebot merged commit 67c66cd into pingcap:master Jun 23, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jun 23, 2020
@YuJuncen @ti-srebot
cherry pick pingcap#3656 to release-3.1
de5722d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 23, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 23, 2020

cherry pick to release-3.1 in PR #3777

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jun 23, 2020
@YuJuncen @ti-srebot
cherry pick pingcap#3656 to release-4.0
8887b9a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 23, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 23, 2020

cherry pick to release-4.0 in PR #3779

ti-srebot added a commit that referenced this pull request Jun 23, 2020
@ti-srebot @YuJuncen
br: fix an expression that isn't accurate enough (#3656) (#3777)
ebbe597 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
ti-srebot added a commit that referenced this pull request Jun 23, 2020
@ti-srebot @YuJuncen
br: fix an expression that isn't accurate enough (#3656) (#3779)
746cb90 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 16, 2020
@ran-huang ran-huang mentioned this pull request Jul 16, 2020
Merged
5 tasks
This was referenced Jul 17, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@3pointer 3pointer Awaiting requested review from 3pointer

@BusyJay BusyJay Awaiting requested review from BusyJay

1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ran-huang ran-huang

Labels

status/can-merge Indicates a PR has been approved by a committer. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

backup 过程中允许 GC

4 participants

@YuJuncen @ti-srebot @TomShawn @ran-huang