Skip to content

br: refine an expression #3303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 17, 2020
Merged

br: refine an expression #3303

merged 2 commits into from
Jul 17, 2020

Conversation

@ran-huang
Copy link
Contributor

@ran-huang ran-huang commented Jul 16, 2020

Signed-off-by: Ran huangran@pingcap.com

What is changed, added or deleted? (Required)

Refine an expression.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@ran-huang
br: refine an expression
6b6c5ef 
Signed-off-by: Ran <huangran@pingcap.com>
@ran-huang ran-huang requested review from TomShawn and YuJuncen July 16, 2020 12:33
@ran-huang ran-huang added needs-cherry-pick-3.1 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jul 16, 2020
TomShawn
TomShawn approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 16, 2020
@YuJuncen
Copy link
Contributor

YuJuncen commented Jul 17, 2020

LGTM

@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 17, 2020

@YuJuncen,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

@ran-huang ran-huang merged commit 8b87731 into pingcap:master Jul 17, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 17, 2020
@ran-huang @ti-srebot
cherry pick pingcap#3303 to release-3.1
0c19801 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 17, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 17, 2020

cherry pick to release-3.1 in PR #3311

TomShawn pushed a commit that referenced this pull request Jul 17, 2020
@ti-srebot @ran-huang
cherry pick #3303 to release-3.1 (#3311)
88f8083 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Ran <huangran@pingcap.com>
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 17, 2020
@ran-huang @ti-srebot
cherry pick pingcap#3303 to release-4.0
4e7890a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 17, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 17, 2020

cherry pick to release-4.0 in PR #3312

ti-srebot added a commit that referenced this pull request Jul 17, 2020
@ti-srebot
br: refine an expression (#3303) (#3312)
9a5c3a9 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ran-huang ran-huang deleted the br_tiny_fix branch July 17, 2020 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YuJuncen YuJuncen Awaiting requested review from YuJuncen

1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ran-huang @YuJuncen @ti-srebot @TomShawn