Skip to content

Update pd-control.md #3995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 20, 2020
Merged

Update pd-control.md #3995

merged 7 commits into from
Jul 20, 2020

Conversation

@yikeke
Copy link
Contributor

@yikeke yikeke commented Jul 17, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@github-actions github-actions bot requested a review from TomShawn July 17, 2020 08:10
@yikeke yikeke added needs-cherry-pick-4.0 translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. labels Jul 17, 2020
@yikeke yikeke removed the request for review from TomShawn July 17, 2020 08:10
@github-actions github-actions bot added translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. status/PTAL This PR is ready for reviewing. labels Jul 17, 2020
@yikeke yikeke removed the translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. label Jul 17, 2020
@yikeke yikeke mentioned this pull request Jul 17, 2020
Merged
5 tasks
@yikeke yikeke marked this pull request as ready for review July 17, 2020 09:51
@yikeke yikeke requested review from ran-huang and rleungx July 17, 2020 09:51
@yikeke yikeke added the size/small Changes of a small size. label Jul 17, 2020
TomShawn
TomShawn approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 17, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 19, 2020

@TomShawn, @rleungx, @ran-huang, PTAL.

@ran-huang ran-huang removed their request for review July 20, 2020 02:32
@yikeke yikeke added the require-LGT1 Indicates that the PR requires an LGTM. label Jul 20, 2020
@yikeke
Copy link
Contributor Author

yikeke commented Jul 20, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 20, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 20, 2020

/run-all-tests

@yikeke yikeke removed the status/can-merge Indicates a PR has been approved by a committer. label Jul 20, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 20, 2020

@rleungx,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

@yikeke
Copy link
Contributor Author

yikeke commented Jul 20, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 20, 2020
@yikeke yikeke merged commit 79eab80 into master Jul 20, 2020
@yikeke yikeke deleted the yikeke-patch-3 branch July 20, 2020 08:14
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 20, 2020
@yikeke @ti-srebot
cherry pick pingcap#3995 to release-4.0
c9fd9b5 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 20, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 20, 2020

cherry pick to release-4.0 in PR #3999

@ti-srebot ti-srebot mentioned this pull request Jul 20, 2020
Merged
5 tasks
yikeke added a commit that referenced this pull request Jul 20, 2020
@ti-srebot @yikeke
cherry pick #3995 to release-4.0 (#3999)
c334400 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rleungx rleungx rleungx approved these changes

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

require-LGT1 Indicates that the PR requires an LGTM. size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yikeke @ti-srebot @rleungx @TomShawn