Skip to content

Update pd-control.md #3323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 20, 2020
Merged

Update pd-control.md #3323

merged 8 commits into from
Jul 20, 2020

Conversation

@yikeke
Copy link
Contributor

@yikeke yikeke commented Jul 17, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@yikeke yikeke requested review from ran-huang and rleungx July 17, 2020 09:41
@yikeke yikeke added needs-cherry-pick-4.0 status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. size/large Changes of a large size. labels Jul 17, 2020
@yikeke yikeke mentioned this pull request Jul 17, 2020
Merged
5 tasks
ran-huang
ran-huang approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 17, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 19, 2020

@ran-huang, @rleungx, PTAL.

@yikeke @ran-huang
Apply suggestions from code review
3a4be7c 
Co-authored-by: Ran <huangran@pingcap.com>
rleungx
rleungx reviewed Jul 20, 2020
View reviewed changes
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 20, 2020

@rleungx,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

@yikeke yikeke merged commit 01a3e1e into pingcap:master Jul 20, 2020
@yikeke yikeke deleted the update-pd-ctl branch July 20, 2020 08:15
@ti-srebot ti-srebot mentioned this pull request Jul 20, 2020
Merged
5 tasks
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 20, 2020
@yikeke @ti-srebot
cherry pick pingcap#3323 to release-4.0
5bf329f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 20, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 20, 2020

cherry pick to release-4.0 in PR #3338

yikeke added a commit that referenced this pull request Jul 20, 2020
@ti-srebot @yikeke
cherry pick #3323 to release-4.0 (#3338)
2dd911a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rleungx rleungx rleungx approved these changes

+1 more reviewer

@ran-huang ran-huang ran-huang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/large Changes of a large size. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yikeke @ti-srebot @rleungx @ran-huang