Skip to content

Conversation

@TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Jul 22, 2020

What is changed, added or deleted? (Required)

Fixes #1768

Also addresses a minor issue in mysql-compatibility where in my #3151 I said that SELECT INTO OUTFILE may not be implemented, but it since has been.

Also propose moving "Compatibility -> MySQL Compatibility" to "MySQL Compatibility" in the menu, to simplify navigation, and add myself as a reviewer to mysql compatibility areas.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@TomShawn TomShawn added translation/from-docs This PR is translated from a PR in pingcap/docs. needs-cherry-pick-3.1 status/PTAL This PR is ready for reviewing. labels Jul 22, 2020
@TomShawn TomShawn requested review from kissmydb, yikeke and zz-jason July 22, 2020 04:07
@yikeke yikeke added the size/small Changes of a small size. label Jul 22, 2020
@yikeke yikeke requested review from lilin90 and removed request for yikeke July 22, 2020 10:09
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 23, 2020
@ti-srebot
Copy link
Contributor

@zz-jason, @kissmydb, @lilin90, PTAL.

1 similar comment
@ti-srebot
Copy link
Contributor

@zz-jason, @kissmydb, @lilin90, PTAL.

Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jul 28, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 28, 2020
@lilin90
Copy link
Member

lilin90 commented Jul 28, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 28, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@lilin90 lilin90 removed the status/PTAL This PR is ready for reviewing. label Jul 28, 2020
@ti-srebot ti-srebot merged commit 2505f1a into pingcap:master Jul 28, 2020
@TomShawn TomShawn deleted the üpdǎte-mysql-cчtibility branch July 28, 2020 10:54
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 28, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #4078

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 28, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #4079

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 28, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4080

TomShawn added a commit that referenced this pull request Jul 28, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn added a commit that referenced this pull request Jul 28, 2020
* cherry pick #4027 to release-3.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* resolve conflicts

* add back content in #3234

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
ti-srebot added a commit that referenced this pull request Jul 28, 2020
* cherry pick #4027 to release-3.1

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* resolve conflicts and add back changes

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs This PR is translated from a PR in pingcap/docs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants