Skip to content

Conversation

@ti-srebot
Copy link
Contributor

cherry-pick #4109 to release-4.0


For reviewers:

@zz-jason @kissmydb 之前因为英文 review 得不是特别仔细,我在对齐的过程中看得仔细些,在 pingcap/docs#3470 修了一些之前没发现的问题,而且在下面的描述里把这 51 个文件的改动概述了下。两位也可以对着中文版再仔细地 review 下技术细节,thanks~

@lilin90 FYI:原 pr 的 .github/assign-by-files.yml 和 check-cluster-status-using-sql-statements.md 在中文版这已经被移除了,所以中文 PR 改动文件数为 51,英文 PR 为 53。

What is changed, added or deleted? (Required)

这个 PR 非常大,为了方便 review,概述如下:

  1. 把原来 system-tables/system-table-information-schema.md 的内容拆成了多个独立的 information-schema/information-schema-xxx.md 文件,多数拆出来的时候内容无大变动,只有一些开头段落和 SQL 例子的更新
  2. 新增了几个 information-schema/information-schema-xxx.md 文档,描述了原来没有文档描述的 information-schema 表
  3. 修了文档位置移动导致的死链
  4. TOC 目录现在变成了下面这个样子(每个 information-schema 表都有自己独立的文档,和 sql-statement 文档类似):
+ 系统表
  + [`mysql`](/mysql-schema.md)
  + INFORMATION_SCHEMA
     + [Overview](/information-schema/information-schema.md)
     + [`ANALYZE_STATUS`](/information-schema/information-schema-analyze-status.md)
     + [`CHARACTER_SETS`](/information-schema/information-schema-character-sets.md)
        ......
  + [`METRICS_SCHEMA`](/metrics-schema.md)
  1. 把后来合并的 update document for system-table-information-schema.md #3470 的改动也整合到了这个 PR

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added size/large Changes of a large size. status/PTAL This PR is ready for reviewing. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. labels Aug 5, 2020
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 5, 2020
@yikeke
Copy link
Contributor

yikeke commented Aug 5, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 5, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit bdf6a73 into pingcap:release-4.0 Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/large Changes of a large size. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants