Skip to content

Update schedule-replicas-by-topology-labels.md #4502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 16, 2020
Merged

Update schedule-replicas-by-topology-labels.md #4502

merged 6 commits into from
Sep 16, 2020

Conversation

@lucklove
Copy link
Member

@lucklove lucklove commented Sep 14, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

TomShawn
TomShawn reviewed Sep 14, 2020
View reviewed changes
@TomShawn TomShawn added needs-cherry-pick-4.0 size/small Changes of a small size. status/PTAL This PR is ready for reviewing. translation/doing This PR’s assignee is translating this PR. labels Sep 14, 2020
@TomShawn
Copy link
Contributor

TomShawn commented Sep 14, 2020

@disksing @rleungx PTAL, thanks!

TomShawn
TomShawn reviewed Sep 14, 2020
View reviewed changes
TomShawn
TomShawn reviewed Sep 14, 2020
View reviewed changes
@TomShawn TomShawn mentioned this pull request Sep 16, 2020
Merged
9 tasks
TomShawn
TomShawn reviewed Sep 16, 2020
View reviewed changes
TomShawn
TomShawn reviewed Sep 16, 2020
View reviewed changes
@ti-srebot
Copy link
Contributor

ti-srebot commented Sep 16, 2020

@disksing,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: docs(slack).

TomShawn
TomShawn approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 16, 2020
@TomShawn TomShawn merged commit 10f4e34 into pingcap:master Sep 16, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Sep 16, 2020
@lucklove @ti-srebot
cherry pick pingcap#4502 to release-4.0
5bfb8ae 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Sep 16, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Sep 16, 2020

cherry pick to release-4.0 in PR #4528

ti-srebot added a commit that referenced this pull request Sep 16, 2020
@ti-srebot
Update schedule-replicas-by-topology-labels.md (#4502) (#4528)
895731f
@ireneontheway ireneontheway removed the translation/doing This PR’s assignee is translating this PR. label Sep 17, 2020
@ireneontheway ireneontheway added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Sep 17, 2020
This was referenced Sep 17, 2020
Merged
Merged
Merged
Merged
@TomShawn TomShawn mentioned this pull request Sep 17, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@disksing disksing disksing approved these changes

@rleungx rleungx Awaiting requested review from rleungx

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ireneontheway ireneontheway

Labels

size/small Changes of a small size. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lucklove @TomShawn @ti-srebot @disksing @ireneontheway