Skip to content

Conversation

@ireneontheway
Copy link
Contributor

@ireneontheway ireneontheway commented Sep 4, 2020

What is changed, added or deleted? (Required)

Improve location-awareness document.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@ireneontheway ireneontheway added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. size/large Changes of a large size. needs-cherry-pick-2.1 status/PTAL This PR is ready for reviewing. labels Sep 4, 2020
@ti-srebot
Copy link
Contributor

@disksing, @yikeke, PTAL.

@yikeke yikeke requested a review from TomShawn September 7, 2020 08:13
@yikeke
Copy link
Contributor

yikeke commented Sep 7, 2020

Please help review this PR. @TomShawn

Before you merge or cherry-pick this PR, note that there are two more issues that need follow-up. @ireneontheway @TomShawn

@yikeke yikeke removed their request for review September 7, 2020 08:18
@TomShawn
Copy link
Contributor

TomShawn commented Sep 7, 2020

Please help review this PR. @TomShawn

Please note that there are two more issues that need follow-up. @ireneontheway @TomShawn

Got it, thanks~

@ti-srebot
Copy link
Contributor

@TomShawn, @disksing, PTAL.

@ti-srebot
Copy link
Contributor

@ireneontheway, please update your pull request.

> **Note:**
>
> `isolation-level` is empty by default, which means there is no mandatory restriction on the isolation level. To set it, you need to configure `location-labels` for PD and ensure that the value of `isolation-level` is one of `location-labels` names.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ireneontheway Please align pingcap/docs-cn#4502 in this document, thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in dbd5321

Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 17, 2020
@TomShawn TomShawn merged commit 24f31fb into pingcap:master Sep 17, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Sep 17, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 in PR #3927

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Sep 17, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #3928

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Sep 17, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #3929

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Sep 17, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3930

TomShawn added a commit that referenced this pull request Sep 17, 2020
* cherry pick #3825 to release-2.1

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* 2.1-changes

Co-authored-by: ireneontheway <48651140+ireneontheway@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn added a commit that referenced this pull request Sep 17, 2020
* cherry pick #3825 to release-3.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* 3.0-changes

Co-authored-by: ireneontheway <48651140+ireneontheway@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn added a commit that referenced this pull request Sep 17, 2020
* cherry pick #3825 to release-3.1

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* 3.1-change

* Update configure-placement-rules.md

* Update schedule-replicas-by-topology-labels.md

* Update schedule-replicas-by-topology-labels.md

Co-authored-by: ireneontheway <48651140+ireneontheway@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn added a commit that referenced this pull request Sep 17, 2020
* cherry pick #3825 to release-4.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* 4.0-change

Co-authored-by: ireneontheway <48651140+ireneontheway@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ireneontheway ireneontheway deleted the update-location-awareness branch September 17, 2020 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/large Changes of a large size. status/LGT1 Indicates that a PR has LGTM 1. status/require-change Needs the author to address comments. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants