-
Notifications
You must be signed in to change notification settings - Fork 709
improve location-awareness #3825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve location-awareness #3825
Conversation
…ntheway/docs into update-location-awareness
|
Please help review this PR. @TomShawn Before you merge or cherry-pick this PR, note that there are two more issues that need follow-up. @ireneontheway @TomShawn |
Got it, thanks~ |
|
@ireneontheway, please update your pull request. |
| > **Note:** | ||
| > | ||
| > `isolation-level` is empty by default, which means there is no mandatory restriction on the isolation level. To set it, you need to configure `location-labels` for PD and ensure that the value of `isolation-level` is one of `location-labels` names. | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ireneontheway Please align pingcap/docs-cn#4502 in this document, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in dbd5321
TomShawn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-2.1 in PR #3927 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-3.0 in PR #3928 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-3.1 in PR #3929 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #3930 |
* cherry pick #3825 to release-3.1 Signed-off-by: ti-srebot <ti-srebot@pingcap.com> * 3.1-change * Update configure-placement-rules.md * Update schedule-replicas-by-topology-labels.md * Update schedule-replicas-by-topology-labels.md Co-authored-by: ireneontheway <48651140+ireneontheway@users.noreply.github.com> Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
What is changed, added or deleted? (Required)
Improve location-awareness document.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?