Skip to content

Conversation

@sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 7, 2020

cherry-pick #2171 to release-4.0


What is changed, added or deleted? (Required)

Add placement rules configuratoin guide.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

* how-to: add placement rule guide

* fix typos

* address comments from disksing

* how-to: update wording and format

* how-to: update and fix description

Co-authored-by: Lilian Lee <lilin@pingcap.com>
@sre-bot sre-bot mentioned this pull request Apr 7, 2020
5 tasks
@sre-bot sre-bot added type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. v4.0 This PR/issue applies to TiDB v4.0. labels Apr 7, 2020
@sre-bot sre-bot requested review from disksing and lilin90 April 7, 2020 08:47
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 merged commit 0dd78ed into pingcap:release-4.0 Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. v4.0 This PR/issue applies to TiDB v4.0.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants