-
Notifications
You must be signed in to change notification settings - Fork 1.2k
how-to: add placement rule guide #2587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
Signed-off-by: disksing <i@disksing.com>
|
LGTM |
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
how-to/configure/placement-rules.md
Outdated
| pd-ctl config placement-rules show --group=pd --id=default | ||
| ``` | ||
|
|
||
| **查看 Region 2 所匹配的规则列表** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
region 2 是什么?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
how-to/configure/placement-rules.md
Outdated
|
|
||
| 以上操作会将 rule1、rule2 两条规则写入 PD,如果系统中已经存在 GroupID+ID 相同的规则,则会被覆盖。 | ||
|
|
||
| 如果需要删除某条规则,只需要将规则的 `count` 置为 0 即可,对应 GroupID+ID 相同的规则会被删除。如下命令将删除 pd/rule2 这条规则: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
能不能直接提供一条 delete 命令
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
也行,不过只能删一个,所以这个还是要保留,我觉得
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的,晚点可以加一个
|
|
||
| > **注意:** | ||
| > | ||
| > DDL 等操作会导致 table ID 发生变化,需要同步更新对应的规则。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个主意项挺关键的,要不要再命令行提示里面放提醒,真怕用户看不到这行
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tidb-ctl 的输出也有提示
IANTHEREAL
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TomShawn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* how-to: add placement rule document Signed-off-by: disksing <i@disksing.com> * minor update Signed-off-by: disksing <i@disksing.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * address comment Signed-off-by: disksing <i@disksing.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update placement-rules.md * Update placement-rules.md * refine format and language * fix a typo Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> Co-authored-by: Ian <ArGregoryIan@gmail.com> Co-authored-by: TomShawn <1135243111@qq.com>
|
cherry pick to release-3.1 in PR #2610 |
* how-to: add placement rule document Signed-off-by: disksing <i@disksing.com> * minor update Signed-off-by: disksing <i@disksing.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * address comment Signed-off-by: disksing <i@disksing.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update placement-rules.md * Update placement-rules.md * refine format and language * fix a typo Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> Co-authored-by: Ian <ArGregoryIan@gmail.com> Co-authored-by: TomShawn <1135243111@qq.com> Co-authored-by: disksing <i@disksing.com> Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> Co-authored-by: Ian <ArGregoryIan@gmail.com> Co-authored-by: TomShawn <1135243111@qq.com>
* how-to: add placement rule document Signed-off-by: disksing <i@disksing.com> * minor update Signed-off-by: disksing <i@disksing.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * address comment Signed-off-by: disksing <i@disksing.com> * Update how-to/configure/placement-rules.md Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> * Update placement-rules.md * Update placement-rules.md * refine format and language * fix a typo Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> Co-authored-by: Ian <ArGregoryIan@gmail.com> Co-authored-by: TomShawn <1135243111@qq.com>
Signed-off-by: disksing i@disksing.com
What is changed, added or deleted? (Required)
add placement rules configuratoin guide
Which TiDB version(s) do your changes apply to? (Required)
If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.
What is the related PR or file link(s)?
original PR #2246