Skip to content

dr: add --config changefeed.toml in cmd - #22657

Merged
ti-chi-bot[bot] merged 4 commits into
pingcap:masterfrom
hfxsd:add-toml-in-cmd-21483
Mar 31, 2026
Merged

dr: add --config changefeed.toml in cmd#22657
ti-chi-bot[bot] merged 4 commits into
pingcap:masterfrom
hfxsd:add-toml-in-cmd-21483

Conversation

@hfxsd

@hfxsd hfxsd commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@hfxsd hfxsd added needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. ONCALL Relates to documentation oncall. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Mar 31, 2026
@hfxsd hfxsd self-assigned this Mar 31, 2026
@ti-chi-bot ti-chi-bot Bot added contribution This PR is from a community contributor. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 31, 2026
@hfxsd
hfxsd requested a review from asddongmen March 31, 2026 03:04

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a placeholder file named temp.md. Feedback indicates that the file lacks descriptive naming and the actual technical content required for TiDB documentation, specifically regarding the --config flag. Additionally, the file is missing a trailing newline.

I am having trouble creating individual review comments. Click here to see my feedback.

temp.md (1)

medium

The filename temp.md and its content appear to be placeholders. This does not meet the criteria for completeness and clarity required for TiDB documentation. Additionally, the file is missing a trailing newline. Please provide a descriptive filename and the actual technical content for the --config flag as described in the pull request title.

References
  1. Documentation should be complete, clear, and provide useful information to users. (link)

github-actions Bot and others added 2 commits March 31, 2026 03:05
Synced from: pingcap/docs-cn#21483
Target PR: pingcap#22657
AI Provider: gemini

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@hfxsd

hfxsd commented Mar 31, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@ti-chi-bot

ti-chi-bot Bot commented Mar 31, 2026

Copy link
Copy Markdown

@asddongmen: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hfxsd hfxsd added the lgtm label Mar 31, 2026
@hfxsd

hfxsd commented Mar 31, 2026

Copy link
Copy Markdown
Contributor Author

/approve

@ti-chi-bot

ti-chi-bot Bot commented Mar 31, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Mar 31, 2026
@ti-chi-bot
ti-chi-bot Bot merged commit a118ed1 into pingcap:master Mar 31, 2026
12 checks passed
@ti-chi-bot

Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #22659.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Mar 31, 2026
Synced from: pingcap/docs-cn#21483
Target PR: pingcap#22657
AI Provider: gemini

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved contribution This PR is from a community contributor. lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. ONCALL Relates to documentation oncall. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants