Skip to content

ticdc: clarify rolling upgrade guidance - #22707

Merged
ti-chi-bot[bot] merged 4 commits into
pingcap:masterfrom
lilin90:ticdc/clarify-old-arch-upgrade-guidance-21496
Apr 8, 2026
Merged

ticdc: clarify rolling upgrade guidance#22707
ti-chi-bot[bot] merged 4 commits into
pingcap:masterfrom
lilin90:ticdc/clarify-old-arch-upgrade-guidance-21496

Conversation

@lilin90

@lilin90 lilin90 commented Apr 7, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Clarify the rolling-upgrade guidance for old-architecture TiCDC and compatibility for TiCDC.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@lilin90 lilin90 added area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Apr 7, 2026
@ti-chi-bot ti-chi-bot Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 7, 2026
@lilin90 lilin90 self-assigned this Apr 7, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a placeholder file named temp.md. The review feedback identifies that the file lacks a proper top-level heading and contains placeholder text that does not meet documentation standards, providing a suggestion to include a relevant H1 heading in sentence case.

I am having trouble creating individual review comments. Click here to see my feedback.

temp.md (1)

medium

The content of this file is placeholder text and does not align with the pull request's objective to clarify TiCDC rolling upgrade guidance. Additionally, the file lacks a top-level heading, which violates the Markdown style guide (MD041). Please replace this with the intended documentation content and ensure it starts with a proper H1 heading in sentence case.

# TiCDC rolling upgrade guidance

References
  1. The first line in a file should be a top-level heading (MD041). (link)
  2. Use sentence case for headings. (link)

@ti-chi-bot ti-chi-bot Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 7, 2026
Comment thread ticdc/ticdc-compatibility.md Outdated
@lilin90
lilin90 requested a review from hfxsd April 7, 2026 10:11
@ti-chi-bot

ti-chi-bot Bot commented Apr 7, 2026

Copy link
Copy Markdown

@wlwilliamx: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lilin90

lilin90 commented Apr 8, 2026

Copy link
Copy Markdown
Member Author

/approve

@ti-chi-bot

ti-chi-bot Bot commented Apr 8, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lilin90 lilin90 removed needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Apr 8, 2026
@ti-chi-bot
ti-chi-bot Bot merged commit 9dcc326 into pingcap:master Apr 8, 2026
12 checks passed
@ti-chi-bot

Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #22711.

@lilin90
lilin90 deleted the ticdc/clarify-old-arch-upgrade-guidance-21496 branch April 8, 2026 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants