cloud: update premium public preview docs#22809
cloud: update premium public preview docs#22809ti-chi-bot[bot] merged 17 commits intorelease-8.5from
Conversation
* *: update premium for preview * Expand feature availability notes to include Premium Updated documentation to consistently mention that various features and tables are not available on TiDB Cloud Starter, Essential, and Premium clusters, instead of only Starter and Essential. This improves clarity for users regarding feature support across all TiDB Cloud tiers.
ti-chi-bot
Bot
added
the
area/develop
ti-chi-bot
Bot
added
missing-translation-status
Oreoxmt
added
translation/no-need
|
/hold |
ti-chi-bot
Bot
added
the
do-not-merge/hold
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds connection instructions for TiDB Cloud Premium across various GUI tools and sample applications, including compatibility notes and environment variable configurations. The reviewer noted an inconsistency in the naming of the SSL environment variable across several files and recommended using USE_SSL instead of TIDB_ENABLE_SSL to align with existing naming conventions in the repository.
| "TIDB_PASSWORD": "{password}", | ||
| "TIDB_ENABLE_SSL": "true" |
There was a problem hiding this comment.
The variable name TIDB_ENABLE_SSL is inconsistent with the USE_SSL naming convention used in other sample applications in this repository. Consider using USE_SSL for consistency.
| TIDB_USER='{prefix}.root' | ||
| TIDB_PASSWORD='{password}' | ||
| TIDB_DB_NAME='test' | ||
| TIDB_ENABLE_SSL='true' |
There was a problem hiding this comment.
The variable name TIDB_ENABLE_SSL is inconsistent with the USE_SSL naming convention used in other sample applications in this repository. Consider using USE_SSL for consistency.
| TIDB_USER='root' | ||
| TIDB_PASSWORD='{password}' | ||
| TIDB_DB_NAME='test' | ||
| TIDB_ENABLE_SSL='false' |
There was a problem hiding this comment.
The variable name TIDB_ENABLE_SSL is inconsistent with the USE_SSL naming convention used in other sample applications in this repository. Consider using USE_SSL for consistency.
| TIDB_USER={user} | ||
| TIDB_PASSWORD={password} | ||
| TIDB_DATABASE=test | ||
| TIDB_ENABLE_SSL=false |
There was a problem hiding this comment.
The variable name TIDB_ENABLE_SSL is inconsistent with the USE_SSL naming convention used in other sample applications in this repository. Consider using USE_SSL for consistency.
| TIDB_USER={user} | ||
| TIDB_PASSWORD={password} | ||
| TIDB_DATABASE=test | ||
| TIDB_ENABLE_SSL=false |
There was a problem hiding this comment.
The variable name TIDB_ENABLE_SSL is inconsistent with the USE_SSL naming convention used in other sample applications in this repository. Consider using USE_SSL for consistency.
| TIDB_USER='{user}' | ||
| TIDB_PASSWORD='{password}' | ||
| TIDB_DB_NAME='test' | ||
| TIDB_ENABLE_SSL='false' |
There was a problem hiding this comment.
The variable name TIDB_ENABLE_SSL is inconsistent with the USE_SSL naming convention used in other sample applications in this repository. Consider using USE_SSL for consistency.
| TIDB_USER={user} | ||
| TIDB_PASSWORD={password} | ||
| TIDB_DATABASE=test | ||
| TIDB_ENABLE_SSL=false |
There was a problem hiding this comment.
The variable name TIDB_ENABLE_SSL is inconsistent with the USE_SSL naming convention used in other sample applications in this repository. Consider using USE_SSL for consistency.
ti-chi-bot
Bot
added
the
size/XXL
[LGTM Timeline notifier]Timeline:
|
|
/approve |
|
/unhold |
ti-chi-bot
Bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Oreoxmt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7 participants
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?