release-8.5.6: fix Dumpling MySQL 8.4 support wording#23223
Merged
ti-chi-bot[bot] merged 1 commit intoJul 25, 2026
Conversation
'terminology' was an inaccurate translation of the Chinese original '二进制日志命名' (binary log naming). Change to 'naming' for accuracy.
ti-chi-bot
Bot
added
missing-translation-status
Contributor
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
qiancai
approved these changes
Jul 25, 2026
[LGTM Timeline notifier]Timeline:
|
qiancai
added
translation/no-need
ti-chi-bot
Bot
removed
the
missing-translation-status
Collaborator
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
In response to a cherrypick label: new pull request created to branch |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Fix inaccurate English wording in release-8.5.6.md. Changed "updated MySQL binary log terminology" to "updated MySQL binary log naming" to match the Chinese original "二进制日志命名" (binary log naming).
The inaccurate English wording "terminology" caused the Japanese translation to use "用語" (terminology), which sounds unnatural in Japanese. The Chinese original "命名" (naming) is more specific to binary log naming conventions. This fix will also correct the downstream Japanese translation when the weekly diff translation runs.
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?