Skip to content

i18n(ja): remove stray Japanese quote marks around English UI labels - #23551

Merged
qiancai merged 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-stray-quotes-english-labels-2026-08-18
Aug 19, 2026
Merged

i18n(ja): remove stray Japanese quote marks around English UI labels#23551
qiancai merged 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-stray-quotes-english-labels-2026-08-18

Conversation

@yahonda

@yahonda yahonda commented Aug 18, 2026

Copy link
Copy Markdown
Member

What is changed

Corpus-wide sweep for a defect pattern first identified and scoped in PR #23519: a bolded English UI label wrapped in Japanese kagi-kakko quotes (**「Label」**) even though EN's own doc has no such quote decoration at that position (plain **Label**). PR #23519 only fixed the sites it directly touched; this covers the remaining 52 files found via a fresh corpus-wide scan (94 instances).

Each instance was verified against the release-8.5 (English) source before fixing:

**「OK」**  →  **OK**
**「Amazon S3」**  →  **Amazon S3**
**「MySQL Connections」**  →  **MySQL Connections**

Quotes wrapping genuinely Japanese-translated UI references (e.g. 「接続」, 「データソース」) were left untouched — that quoting is normal and unrelated to this defect class.

Also fixed a handful of adjacent defects found while touching these lines:

  • particles (を/の) trapped inside a bold span's closing ** instead of sitting outside it
  • two straddling-bracket cases where an opening landed outside the ** span while its closing landed inside

Verification

  • Bracket/**-parity check across the full diff: 0 issues.
  • Every fix confirmed against the EN source at the exact sentence position before applying.

@ti-chi-bot ti-chi-bot Bot added the area/develop This PR relates to the area of TiDB App development. label Aug 18, 2026
@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@yahonda, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 31 minutes

Limit details: You’ve used all 4 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 9b24b9bf-e524-4fe8-9a39-db3f79867b45

📥 Commits

Reviewing files that changed from the base of the PR and between b77d42f and 3ae9c54.

📒 Files selected for processing (52)
  • ai/integrations/tidb-mcp-claude-code.md
  • ai/integrations/tidb-mcp-cursor.md
  • ai/integrations/tidb-mcp-windsurf.md
  • best-practices/massive-regions-best-practices.md
  • dashboard/dashboard-statement-details.md
  • dashboard/top-sql.md
  • develop/dev-guide-aws-appflow-integration.md
  • develop/dev-guide-bookshop-schema-design.md
  • develop/dev-guide-build-cluster-in-cloud.md
  • develop/dev-guide-gui-datagrip.md
  • develop/dev-guide-gui-dbeaver.md
  • develop/dev-guide-gui-mysql-workbench.md
  • develop/dev-guide-gui-navicat.md
  • garbage-collection-configuration.md
  • performance-tuning-practices.md
  • resources/tidb-pdf-generation-tutorial.md
  • schema-cache.md
  • ticdc/integrate-confluent-using-ticdc.md
  • tidb-cloud/backup-and-restore-serverless.md
  • tidb-cloud/backup-and-restore.md
  • tidb-cloud/changefeed-sink-to-apache-kafka.md
  • tidb-cloud/changefeed-sink-to-apache-pulsar.md
  • tidb-cloud/changefeed-sink-to-cloud-storage.md
  • tidb-cloud/changefeed-sink-to-mysql.md
  • tidb-cloud/changefeed-sink-to-tidb-cloud.md
  • tidb-cloud/configure-external-storage-access.md
  • tidb-cloud/connect-via-sql-shell.md
  • tidb-cloud/create-tidb-cluster.md
  • tidb-cloud/data-service-postman-integration.md
  • tidb-cloud/dedicated-external-storage.md
  • tidb-cloud/essential-changefeed-sink-to-kafka.md
  • tidb-cloud/essential-changefeed-sink-to-mysql.md
  • tidb-cloud/import-sample-data-serverless.md
  • tidb-cloud/import-sample-data.md
  • tidb-cloud/manage-projects-and-resources.md
  • tidb-cloud/migrate-sql-shards.md
  • tidb-cloud/monitor-alert-flashduty.md
  • tidb-cloud/monitor-alert-slack.md
  • tidb-cloud/monitor-alert-zoom.md
  • tidb-cloud/premium/connect-to-premium-via-alibaba-cloud-private-endpoint.md
  • tidb-cloud/premium/create-tidb-instance-premium.md
  • tidb-cloud/premium/migrate-from-op-tidb-premium.md
  • tidb-cloud/premium/tidb-cloud-auditing-premium.md
  • tidb-cloud/releases/release-notes-2023.md
  • tidb-cloud/serverless-private-link-connection-to-self-hosted-kafka-in-alicloud.md
  • tidb-cloud/set-up-private-endpoint-connections-on-alibaba-cloud.md
  • tidb-cloud/tidb-cloud-auditing.md
  • tidb-cloud/tidb-cloud-clinic.md
  • tidb-cloud/tidb-cloud-poc.md
  • tidb-cloud/tidb-cloud-quickstart.md
  • tidb-lightning/tidb-lightning-web-interface.md
  • troubleshoot-high-disk-io.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added the missing-translation-status This PR does not have translation status info. label Aug 18, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign breezewish for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 18, 2026
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Aug 18, 2026
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 18, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-08-18 06:14:51.884861999 +0000 UTC m=+3718277.920957055: ☑️ agreed by qiancai.

@yahonda

yahonda commented Aug 18, 2026

Copy link
Copy Markdown
Member Author

Let me resolve the conflict tomorrow.

@yahonda
yahonda force-pushed the fix-stray-quotes-english-labels-2026-08-18 branch from d098ae4 to c75b937 Compare August 19, 2026 01:05
Corpus-wide sweep for a defect pattern first identified and scoped in
PR pingcap#23519: a bolded English UI label wrapped in Japanese kagi-kakko
quotes (**「Label」**) even though EN's own doc has no such quote
decoration at that position (plain **Label**). PR pingcap#23519 only fixed
the sites it touched directly; this covers the remaining ~52 files
found via a fresh corpus-wide scan.

Each instance was verified against the release-8.5 (English) source
before fixing. Quotes wrapping genuinely Japanese-translated UI
references were left untouched, since that quoting is normal and
unrelated to this defect.

Also fixed a few adjacent defects found while touching these lines:
particles trapped inside a bold span's closing ** instead of sitting
outside it, and two straddling-bracket cases where an opening 「 landed
outside the ** span while its closing 」 landed inside.
@yahonda
yahonda force-pushed the fix-stray-quotes-english-labels-2026-08-18 branch from c75b937 to 3ae9c54 Compare August 19, 2026 05:38
@ti-chi-bot

ti-chi-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown

@qiancai: Your lgtm message is repeated, so it is ignored.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@qiancai
qiancai merged commit a344db9 into pingcap:i18n-ja-release-8.5 Aug 19, 2026
4 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/develop This PR relates to the area of TiDB App development. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants