i18n(ja): remove spurious middle-dots from katakana compound terms - #23693
Conversation
Middle-dot (・) was used to split many katakana technical compound terms that should be written as one continuous word, matching the standing katakana-compound-spacing convention (no separator between katakana words in a single term) and the same pattern already fixed for OLTP in PR pingcap#23692. Examples: インデックス・ネストループ → インデックスネストループ (Index Nested Loop [Join]), プライマリ・ セカンダリ → プライマリセカンダリ, アルター・リソース・グループ → アルターリソースグループ, データベース・アズ・ア・サービス → データベースアズアサービス (Database as a Service). Also found and fixed 2 GitHub-username mistransliterations where a middle-dot had been incorrectly inserted into a single username (release-6.5.6.md, release-7.1.3.md: CharlesCheung96, tonyxuqqi). Left untouched (verified false positives / legitimate uses): - Foreign personal names, where middle-dot is the correct Japanese convention (e.g. Ketanji Brown Jackson in ai/integrations/vector-search-integrate-with-langchain.md). - Middle-dot used as a genuine 'and' list separator between two distinct EN-sourced actions/items (e.g. 構成・セットアップ = configure and set up, 開発・テスト = development and testing) — these are correct Japanese and not part of this defect class. - 3 sites where EN explicitly uses "and" between two distinct actions (incremental backup and restore; backup and restore functions; merge and import) were reworded with と/および instead of silently joining into one compound, to preserve the "and" meaning.
|
Skipping CI for Draft Pull Request. |
📝 WalkthroughWalkthroughThe pull request updates Japanese documentation terminology, punctuation, translations, and contributor attributions across general guides, BR and DR pages, release notes, and TiDB Cloud documentation. It introduces no functional or technical changes. ChangesDocumentation terminology updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: 🔵 Low · up to The PR standardizes Japanese technical-term spelling across 40 documentation files, but a few release-note edits still omit contributor @ markers and contain one duplicated character. The changes are mergeable with explicit owner follow-up to correct these localized text issues. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Description checkExplanation The description explains the scope, rationale, examples, exclusions, affected documentation version, and AI involvement. The related-link fields are blank, but they are not essential because the changes and scope are documented clearly. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (40 skipped: 40 unsupported.) ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
…n-vs-feature wording, and Capital Bikeshare license link text
…ege-management.md Nearly every heading in the privilege-related-operations section of privilege-management.md had translated the literal SQL command name (matching a section heading per statement, e.g. ALTER, BACKUP, CREATE DATABASE, GRANT, REVOKE, CREATE/ALTER/DROP RESOURCE GROUP) into descriptive Japanese, instead of keeping it as literal English like the rest of the corpus consistently does (confirmed via TOC.md and sql-statements/sql-statement-overview.md, which both correctly keep these as literal backtick-quoted English). 31 headings restored. Also fixed the matching CREATE/DROP RESOURCE GROUP entries in tidb-resource-control-ru-groups.md's See also list, which had the same descriptive-Japanese mistranslation for 2 of its 3 sibling entries.
… privilege-management.md Multiple defects found via user's line-by-line review of the privilege-related-operations section: - Broken verb ending (X権限ている -> X権限を持っている) in the ALTER bullet list - RENAME TABLE description ended as an incomplete sentence fragment with no verb, and used incorrect する後 instead of した後 - SHOW CREATE TABLE / SHOW GRANTS / User+Host sentences missing a subject-marking は particle, causing misreadable run-ons - SHOW GRANTS description had SELECT and mysql swapped (said "mysql privilege to the SELECT database" instead of "SELECT privilege to the mysql database") - Same swap defect in the user-table paragraph (DELETE/user reversed) and in the tables_priv/columns_priv paragraph (% and tables_priv reversed) - ALTER USER dropped the の particle, inconsistent with every sibling entry's "Xの権限が必要です" pattern - GRANT section had a garbled single-noun-phrase structure instead of mirroring the correctly-structured REVOKE section right below it (both should say "X権限と、Yの権限が必要です") - SET RESOURCE GROUP: missing が particle before 「ONに設定されている場合」 - Time of effect section: missing などの before both statement-list summaries, making 4 example statements read as if they were collectively named "privilege management statement(s)" rather than examples of that category
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Team
Run ID: f2818fb0-d1bf-4cd9-b590-b83733850dff
📒 Files selected for processing (40)
ai/examples/image-search-with-pytidb.mdbr/br-checkpoint-backup.mdbr/br-checkpoint-restore.mddevelop/dev-guide-connection-parameters.mddevelop/dev-guide-create-table.mddevelop/dev-guide-hybrid-oltp-and-olap-queries.mddr-secondary-cluster.mdexplore-htap.mdfaq/deploy-and-maintain-faq.mdglossary.mdimport-example-data.mdmigrate-from-tidb-to-tidb.mdmigration-overview.mdoptimizer-hints.mdprivilege-management.mdreleases/release-6.1.0.mdreleases/release-6.5.6.mdreleases/release-7.1.0.mdreleases/release-7.1.3.mdsql-plan-management.mdtidb-cloud/architecture-concepts.mdtidb-cloud/dedicated/_index.mdtidb-cloud/essential/_index.mdtidb-cloud/premium/_index.mdtidb-cloud/secure-connections-to-serverless-clusters.mdtidb-cloud/starter/_index.mdtidb-cloud/tidb-cloud-faq.mdtidb-cloud/v6.5-performance-benchmarking-with-sysbench.mdtidb-cloud/v6.5-performance-benchmarking-with-tpcc.mdtidb-cloud/v7.1-performance-benchmarking-with-sysbench.mdtidb-cloud/v7.1-performance-benchmarking-with-tpcc.mdtidb-cloud/v7.5-performance-benchmarking-with-sysbench.mdtidb-cloud/v7.5-performance-benchmarking-with-tpcc.mdtidb-cloud/v8.1-performance-benchmarking-with-sysbench.mdtidb-cloud/v8.1-performance-benchmarking-with-tpcc.mdtidb-cloud/v8.5-performance-benchmarking-with-sysbench.mdtidb-cloud/v8.5-performance-benchmarking-with-tpcc.mdtidb-resource-control-ru-groups.mdtidb-resource-control-runaway-queries.mdtroubleshoot-lock-conflicts.md
Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review.
| - [`compression`](/ticdc/ticdc-changefeed-config.md) : REDOログファイルの圧縮動作を設定できます[#10176](https://github.com/pingcap/tiflow/issues/10176) @[sdojjy](https://github.com/sdojjy) | ||
| - [`changefeed-error-stuck-duration`](/ticdc/ticdc-changefeed-config.md) : 内部エラーまたは例外が発生したときに、変更フィードが自動的に再試行される期間を設定できます[#9875](https://github.com/pingcap/tiflow/issues/9875) @[asddongmen](https://github.com/asddongmen) | ||
| - [`sink.cloud-storage-config`](/ticdc/ticdc-changefeed-config.md) : オブジェクトストレージにデータを複製するときに履歴データの自動クリーンアップを設定できます[チャールズ・チュン96](https://github.com/CharlesCheung96) [#10109](https://github.com/pingcap/tiflow/issues/10109) | ||
| - [`sink.cloud-storage-config`](/ticdc/ticdc-changefeed-config.md) : オブジェクトストレージにデータを複製するときに履歴データの自動クリーンアップを設定できます[CharlesCheung96](https://github.com/CharlesCheung96) [#10109](https://github.com/pingcap/tiflow/issues/10109) |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Preserve the @ marker in contributor attributions.
The changed contributor links omit the marker used by the surrounding release notes.
releases/release-6.5.6.md#L24-L24: Add@beforeCharlesCheung96.releases/release-6.5.6.md#L36-L36: Add@beforetonyxuqqi.releases/release-7.1.3.md#L21-L21: Add@beforeCharlesCheung96.
📍 Affects 2 files
releases/release-6.5.6.md#L24-L24(this comment)releases/release-6.5.6.md#L36-L36releases/release-7.1.3.md#L21-L21
| スナップショットの復元やログの復元は、ディスク枯渇やノードクラッシュなどの回復可能なエラーにより中断される可能性があります。TiDB v7.1.0より前のバージョンでは、エラーに対処した後でも中断前の復元の進行状況が無効になり、復元を最初からやり直す必要がありました。大規模クラスターでは、これはかなりの追加コストが発生します。 | ||
|
|
||
| TiDB v7.1.0以降、バックアップ&リストア(BR)にチェックポイント・リストア機能が導入され、中断されたリストアを再開できるようになりました。この機能により、中断されたリストアのリカバリ進行状況の大部分を保持できます。 | ||
| TiDB v7.1.0以降、バックアップ&リストア(BR)にチェックポイントリストア機能が導入され、中断されたリストアを再開できるようになりました。この機能により、中断されたリストアのリカバリ進行状況の大部分を保持できます。 |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Remove the duplicated 「再」.
再再開 is a typo. Use 再開 for the restore operation.
As per path instructions: “For every actionable issue, provide a GitHub committable suggestion block containing the exact replacement text whenever the fix can be safely and completely applied to contiguous lines in the diff.”
Committable suggestion
| TiDB v7.1.0以降、バックアップ&リストア(BR)にチェックポイントリストア機能が導入され、中断されたリストアを再開できるようになりました。この機能により、中断されたリストアのリカバリ進行状況の大部分を保持できます。 | |
| TiDB v7.1.0以降、バックアップ&リストア(BR)にチェックポイントリストア機能が導入され、中断されたリストアを再開できるようになりました。この機能により、中断されたリストアのリカバリ進行状況の大部分を保持できます。 |
Source: Path instructions
[LGTM Timeline notifier]Timeline:
|
What is changed, added or deleted? (Required)
Middle-dot (・) was used to split many katakana technical compound terms that should be written as one continuous word, matching the standing katakana-compound-spacing convention (no separator between katakana words in a single term) and the same pattern already fixed for OLTP in PR #23692.
Examples:
インデックス・ネストループ→インデックスネストループ(Index Nested Loop [Join]),プライマリ・セカンダリ→プライマリセカンダリ,アルター・リソース・グループ→アルターリソースグループ,データベース・アズ・ア・サービス→データベースアズアサービス(Database as a Service),ハイブリッド・トランザクション・アンド・アナリティカル・プロセッシング→ハイブリッドトランザクションアンドアナリティカルプロセッシング(HTAP full expansion).Also found and fixed 2 GitHub-username mistransliterations where a middle-dot had been incorrectly inserted into a single username (
release-6.5.6.md,release-7.1.3.md: CharlesCheung96, tonyxuqqi).This was a mechanical, corpus-wide sweep (regex-based) — the user will do their own pass to catch any remaining false positives. Known categories already excluded/reviewed during this pass:
ai/integrations/vector-search-integrate-with-langchain.md— found by the mechanical sweep, verified as a real name, and reverted).構成・セットアップ= configure and set up,開発・テスト= development and testing) — left untouched, these are correct Japanese.40 files changed. See [[ja-katakana-middle-dot-broader-sweep]] memory note for the original scoping.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit