Skip to content

i18n(ja): remove stray brace artifacts and fix accompanying word-order swaps - #23699

Merged
qiancai merged 10 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-stray-brace-sweep
Sep 3, 2026
Merged

i18n(ja): remove stray brace artifacts and fix accompanying word-order swaps#23699
qiancai merged 10 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-stray-brace-sweep

Conversation

@yahonda

@yahonda yahonda commented Sep 2, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Corpus-wide sweep for a stray, unpaired } character left over from a botched machine-translation pass (usually right after a backtick-quoted code span). Most occurrences of this artifact were also accompanied by a word-order swap of the two nearby terms relative to EN, since the artifact and the swap appear to share the same root cause in the original machine-translation output.

Fixed 66 occurrences across 44 files:

  • Most sites: removed the stray } and corrected a swapped pair of terms (e.g. CREATE DATABASE/file-name order, config-item/value order, AUTO_RANDOM/AUTO_INCREMENT order)
  • Some sites: the term order was already correct, only the stray } needed removing
  • A few sites needed a fuller reconstruction (e.g. index-advisor.md, statement-summary-tables.md, tikv-configuration-file.md, tidb-troubleshooting-map.md, placement-rules-in-sql.md) where more than two terms had been cross-wired, or where a word (e.g. "environment variable", "index", "line terminator", "CSV file") had been dropped entirely
  • A same-sentence terminology inconsistency (リージョン vs 領域 for the same EN "Region" concept) in tikv-configuration-file.md
  • A repeated key/file swap ("value of config.toml within the output-dir file" instead of "value of output-dir within the config.toml file") in sync-diff-inspector-overview.md, fixed across all 4 occurrences

Each fix was verified against the corresponding EN source in release-8.5, including an independent 1:1 review pass. One related site was intentionally left untouched (out of scope for this PR): tidb-cloud/get-started-with-cli.md, already fixed in #23698.

Which TiDB version(s) do your changes apply to? (Required)

  • i18n-ja-release-8.5 (TiDB Japanese documentation for TiDB 8.5 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Documentation
    • Corrected Japanese wording, formatting, terminology, and typographical errors across AI, database, migration, TiDB Cloud, and troubleshooting documentation.
    • Clarified setup instructions, configuration guidance, SQL examples, data type mappings, migration steps, and command usage.
    • Fixed inaccurate descriptions involving primary-key selection, TLS configuration, connection options, schema files, and TiCDC connections.
    • Removed stray characters and corrected malformed sentences without changing product behavior.

@ti-chi-bot

ti-chi-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kissmydb for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

Next included review available in 40 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: f3a5cfc3-5235-485c-9da2-dc7c49b279cd

📥 Commits

Reviewing files that changed from the base of the PR and between dc5971b and d3491a1.

📒 Files selected for processing (11)
  • ai/quickstart-via-sql.md
  • develop/java-app-best-practices.md
  • dm/dm-compatibility-catalog.md
  • dm/feature-shard-merge-pessimistic.md
  • partitioned-table.md
  • releases/release-8.0.0.md
  • sync-diff-inspector/sync-diff-inspector-overview.md
  • system-variables.md
  • ticdc/ticdc-compatibility.md
  • tidb-cloud/essential-changefeed-overview.md
  • tikv-configuration-file.md
📝 Walkthrough

Walkthrough

This pull request corrects Japanese documentation wording, terminology, file references, examples, and stray characters across AI, development, migration, SQL, TiDB Cloud, and troubleshooting pages. No code behavior or public entity declarations changed.

Changes

AI documentation examples

Layer / File(s) Summary
AI example wording
ai/integrations/*, ai/quickstart-via-sql.md
Corrected descriptions for EMBED_TEXT(), SimpleDirectoryReader, and a 3-dimensional VECTOR column.

Development guides and application examples

Layer / File(s) Summary
Development and application instructions
develop/dev-guide-create-table.md, develop/dev-guide-proxysql-integration.md, develop/dev-guide-sample-application-*, develop/java-app-best-practices.md, develop/serverless-driver*.md
Corrected configuration guidance, sample query descriptions, MyBatis syntax, ExecutorType wording, and Prisma setup instructions.

Migration and Data Migration guides

Layer / File(s) Summary
Migration instructions
dm/*, faq/manage-cluster-faq.md, migrate-from-*-files-to-tidb.md, migrate-large-mysql-shards-to-tidb.md
Corrected Data Migration descriptions, thread settings, schema-file assignments, CSV terminology, query-status wording, and config.toml references.

SQL and database reference text

Layer / File(s) Summary
SQL reference descriptions
index-advisor.md, information-schema/*, partitioned-table.md, placement-rules-in-sql.md, releases/*, sql-mode.md, sql-statements/*, statement-summary-tables.md, system-variables.md
Corrected Japanese explanations for SQL behavior, system variables, partitioning, placement rules, resource groups, indexes, and statement summary tables.

Cloud, operational, and troubleshooting documentation

Layer / File(s) Summary
Operational and cloud documentation
sync-diff-inspector/*, ticdc/*, tidb-cloud/*, tidb-troubleshooting-map.md, tikv-configuration-file.md
Corrected file paths, connection parameters, changefeed restrictions, endpoint descriptions, troubleshooting text, and backup-file examples.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: invalid-email-address

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly explains the documentation-only fixes, affected scope, validation against the English source, version applicability, and AI involvement. The required sections are present; blan…
Title check ✅ Passed The title clearly summarizes the main changes: removing stray brace artifacts and correcting related word-order issues in Japanese documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description clearly explains the documentation-only fixes, affected scope, validation against the English source, version applicability, and AI involvement. The required sections are present; blank reference-link fields are non-critical.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (8 skipped: 8 unsupported.)

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. area/develop This PR relates to the area of TiDB App development. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 2, 2026
@yahonda
yahonda marked this pull request as ready for review September 2, 2026 05:59
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2026
@yahonda yahonda changed the title i18n(ja): remove stray MT-artifact braces and fix accompanying word-order swaps i18n(ja): remove stray machine-translation braces and fix accompanying word-order swaps Sep 2, 2026
@yahonda yahonda changed the title i18n(ja): remove stray machine-translation braces and fix accompanying word-order swaps i18n(ja): remove stray brace artifacts and fix accompanying word-order swaps Sep 2, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 7


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: a0e840b8-9461-4a44-ba4e-f52234fffeef

📥 Commits

Reviewing files that changed from the base of the PR and between 23d5ab9 and dc5971b.

📒 Files selected for processing (43)
  • ai/integrations/vector-search-auto-embedding-amazon-titan.md
  • ai/integrations/vector-search-integrate-with-llamaindex.md
  • ai/quickstart-via-sql.md
  • develop/dev-guide-create-table.md
  • develop/dev-guide-proxysql-integration.md
  • develop/dev-guide-sample-application-aws-lambda.md
  • develop/dev-guide-sample-application-nextjs.md
  • develop/dev-guide-sample-application-nodejs-mysql2.md
  • develop/dev-guide-sample-application-nodejs-mysqljs.md
  • develop/dev-guide-sample-application-nodejs-prisma.md
  • develop/dev-guide-sample-application-nodejs-typeorm.md
  • develop/java-app-best-practices.md
  • develop/serverless-driver-prisma-example.md
  • develop/serverless-driver.md
  • dm/dm-compatibility-catalog.md
  • dm/feature-shard-merge-pessimistic.md
  • dm/manually-upgrade-dm-1.0-to-2.0.md
  • dm/task-configuration-file-full.md
  • faq/manage-cluster-faq.md
  • index-advisor.md
  • information-schema/information-schema-slow-query.md
  • migrate-from-csv-files-to-tidb.md
  • migrate-from-parquet-files-to-tidb.md
  • migrate-from-sql-files-to-tidb.md
  • migrate-large-mysql-shards-to-tidb.md
  • partitioned-table.md
  • placement-rules-in-sql.md
  • releases/release-8.0.0.md
  • sql-mode.md
  • sql-statements/sql-statement-alter-resource-group.md
  • sql-statements/sql-statement-create-index.md
  • statement-summary-tables.md
  • sync-diff-inspector/sync-diff-inspector-overview.md
  • system-variables.md
  • ticdc/ticdc-compatibility.md
  • tidb-cloud/data-service-oas-with-nextjs.md
  • tidb-cloud/essential-changefeed-overview.md
  • tidb-cloud/integrate-tidbcloud-with-netlify.md
  • tidb-cloud/integrate-tidbcloud-with-vercel.md
  • tidb-cloud/migrate-from-mysql-using-aws-dms.md
  • tidb-cloud/set-up-private-endpoint-connections-on-alibaba-cloud.md
  • tidb-troubleshooting-map.md
  • tikv-configuration-file.md

Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review.

Comment thread develop/dev-guide-proxysql-integration.md
Comment thread partitioned-table.md Outdated
Comment thread sql-mode.md
Comment thread sync-diff-inspector/sync-diff-inspector-overview.md Outdated
Comment thread ticdc/ticdc-compatibility.md Outdated
Comment thread tidb-cloud/data-service-oas-with-nextjs.md
Comment thread tidb-troubleshooting-map.md
yahonda added a commit to yahonda/docs that referenced this pull request Sep 3, 2026
yahonda added a commit to yahonda/docs that referenced this pull request Sep 3, 2026
yahonda and others added 9 commits September 3, 2026 11:11
…rder swaps (part 1)

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…rder swaps (part 2)

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
"SQL ステートメント`ORDER BY`" read as an ungrammatical bare compound;
added の to connect ステートメント and ORDER BY properly.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The JA sentence dropped "index" entirely and mislabeled the index name
idx as if it were the expression, instead of LOWER(col1). EN: "create
the expression index idx on the expression LOWER(col1)".

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The sentence dropped "line terminator" (行終端記号) and "CSV file"
entirely, leaving only two bare backtick terms with no connecting
words. EN: "You need to explicitly specify the line terminator
terminator for a strict-format CSV file."

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
- dev-guide-sample-application-nodejs-typeorm.md: restored dropped
  "environment variable" and ".env file" wording
- placement-rules-in-sql.md: fixed a dangling sentence fragment
  ("...1つFollower。") and a garbled second bullet missing "region"
  and "label" wording
- tidb-cloud/integrate-tidbcloud-with-vercel.md: moved the misplaced
  "dynamic IP addresses" link (and the word 動的) back to its correct
  position earlier in the sentence

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The sentence used リージョン for the first Region mention but switched
to the generic 領域 for the second, even though EN uses "Region" (the
TiKV concept) both times.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…toml swaps

4 sentences in this file said "X is the value of config.toml within
the Y file", when EN says "X is the value of Y within the config.toml
file" — Y (output-dir, task.target-instance) is the config KEY and
config.toml is the FILE it lives in, not the other way around.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@yahonda
yahonda force-pushed the fix-ja-stray-brace-sweep branch from 45ed796 to b564943 Compare September 3, 2026 02:12
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Sep 3, 2026
@qiancai

qiancai commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

@yahonda Coderabbit made some commitable suggestions on this PR. PTAL. Thanks.

@yahonda

yahonda commented Sep 3, 2026

Copy link
Copy Markdown
Member Author

@qiancai Reviewed all 7 CodeRabbit suggestions against the EN source (release-8.5):

  • 3 were genuine translation defects and are fixed (partitioned-table.md dropped particles, sync-diff-inspector-overview.md missing verb, ticdc-compatibility.md swapped word order — the last one being exactly this PR's own scope, apparently missed by the original sweep).
  • 4 mirror imprecise/typo wording already present in the EN source itself (dev-guide-proxysql-integration.md, sql-mode.md's "DATATIME" typo, data-service-oas-with-nextjs.md, tidb-troubleshooting-map.md), so I kept those as-is for EN fidelity and replied on each thread with the EN reference.

PTAL.

@qiancai
qiancai merged commit 6b1f679 into pingcap:i18n-ja-release-8.5 Sep 3, 2026
5 of 9 checks passed
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 3, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-09-03 05:41:46.238373452 +0000 UTC m=+1344341.409467568: ☑️ agreed by qiancai.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/develop This PR relates to the area of TiDB App development. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants