i18n(ja): fix function/feature mistranslations - #23704
Conversation
|
Skipping CI for Draft Pull Request. |
ti-chi-bot
Bot
added
the
do-not-merge/work-in-progress
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe pull request updates Japanese documentation and release notes. It standardizes terminology for functions and refines support-related wording. No functional behavior or public declarations change. ChangesJapanese terminology cleanup
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: 🟡 Moderate · up to The Japanese documentation still contains two terminology and wording errors that could mislead readers about SQL functions and operators, so the PR is not merge-ready until those localized corrections are made. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Description checkExplanation The description explains the terminology issue, scope, validation of unchanged cases, affected version, AI involvement, and change-category checklist. The optional reference-link fields are blank, but the required information is complete. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ti-chi-bot
Bot
added
area/develop
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
the
size/M
yahonda
changed the title
ti-chi-bot
Bot
removed
the
do-not-merge/work-in-progress
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Team
Run ID: 143b295c-d66a-44b6-96d3-57342a851b32
📒 Files selected for processing (28)
best-practices/grafana-monitor-best-practices.mddevelop/dev-guide-hybrid-oltp-and-olap-queries.mdfunctions-and-operators/date-and-time-functions.mdfunctions-and-operators/tidb-functions.mdreleases/release-2.0.3.mdreleases/release-2.1.10.mdreleases/release-2.1.12.mdreleases/release-2.1.14.mdreleases/release-2.1.8.mdreleases/release-3.0.2.mdreleases/release-3.0.20.mdreleases/release-4.0.0-beta.1.mdreleases/release-4.0.11.mdreleases/release-4.0.6.mdreleases/release-4.0.7.mdreleases/release-4.0.8.mdreleases/release-5.0.3.mdreleases/release-5.0.4.mdreleases/release-5.1.1.mdreleases/release-5.1.2.mdreleases/release-5.2.0.mdreleases/release-5.4.1.mdreleases/release-6.0.0-dmr.mdreleases/release-6.3.0.mdreleases/release-6.4.0.mdreleases/release-6.5.0.mdreleases/release-7.6.0.mdreleases/release-8.5.5.md
Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review.
ti-chi-bot
Bot
added
size/L
5cd7043 to
628e0dd
Compare
qiancai
added
translation/no-need
Fix 26 occurrences across 24 files where a backtick-quoted SQL/API function name was mistranslated as 機能 (feature) instead of 関数 (function), per the corresponding English source. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
….10.md EN: "Fix a bug of the BETWEEN function in the DATE/DATETIME comparison". JA dropped "comparison" entirely and lacked any connector between DATE and DATETIME, reading as an unnatural bare juxtaposition instead of the intended slash-separated pair. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
16 sites across 8 files used the literal-MT construction "Xを<target> にプッシュダウンするサポート" (a bare noun "support" trailing a relative clause), instead of the corpus's established natural pattern "Xの<target>へのプッシュダウンをサポート" (already used elsewhere, e.g. release-6.3.0.md's elt function bullet). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
EN calls this a function ("Support the JSON_LENGTH(json, path)
function"), matching the file's own later mention of JSON_LENGTH() as
a function. Found via a targeted search for parenthesized identifiers
followed by feature-word, since the earlier automated sweep had
assumed identifiers with parens were low-risk and skipped them.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…-6.3.0.md EN: "Support pushing down the HexIntArg/HexStrArg function to TiFlash" -- confirms this is a function, matching the adjacent leftShift/castTimeAsDuration bullets in the same list. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…1.md Several bullets had multiple [#N](url) reference links split across the sentence (some before the final verb, some after, sometimes in a different order than EN), instead of grouped together as EN has them. Fixed 3 sites: Sequence function, PD config item (2 occurrences), and readpool.unify-read-pool; also normalized one link-order mismatch for the SLOW_QUERY / CLUSTER_SLOW_QUERY bullet. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
628e0dd to
793b23c
Compare
2 participants
What is changed, added or deleted? (Required)
English "function" is ambiguous and gets translated into Japanese as either 関数 (a callable SQL/programming function) or 機能 (a product feature/capability). Found via a high-precision grep pattern (a backtick-quoted identifier immediately followed by 機能) that a number of genuine SQL/API function names had been mistranslated with 機能 instead of 関数.
Fixed 26 occurrences across 24 files where the backtick-quoted identifier is a genuine callable function (SQL built-in functions like
CEIL,ROUND,ABS(),DATE(),REGEXP,JSON_EXTRACT(),WEEK(),translate,stddev_pop, aggregate/window functions likerow_number(), or internal Go API functions likeSendRequest,GetAllMembers,reArrangeFallback,leftShift) where EN explicitly calls it a "function".15 other candidates matching the same grep pattern were checked and confirmed already correct — these are genuine feature/mechanism names (e.g.
AUTO_RANDOMfeature,heartbeatfeature,PreVotefeature,EXPLAINfeatures,mysql_close()functionality — EN says "functionality" not "function" for that one) where EN itself says "feature"/"functionality", not "function".Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit
Avg,row_number(),WEEK(),CURRENT_RESOURCE_GROUP(), and others.