i18n(ja): fix self-referential comparison in soft-pending-compaction-bytes-limit - #23730
Conversation
…bytes-limit
The v8.5.5+ override condition compared
storage.flow-control.soft-pending-compaction-bytes-limit against itself
instead of against this configuration item's own value, as the English
source states ("only when its value is greater than
storage.flow-control.soft-pending-compaction-bytes-limit").
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe v8.5.5 ChangesConfiguration Documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The Japanese TiKV configuration documentation now correctly describes when the flow-control threshold overrides the RocksDB setting. The change is ready to merge. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
[LGTM Timeline notifier]Timeline:
|
What is changed, added or deleted? (Required)
Fix a self-referential comparison in
tikv-configuration-file.md'ssoft-pending-compaction-bytes-limitsection (v8.5.5+ override condition). The Japanese translation comparedstorage.flow-control.soft-pending-compaction-bytes-limitagainst itself instead of comparing this configuration item's own value against it, as the English source states:Before:
After:
This matches the parallel, correctly-translated sentence for
level0-slowdown-writes-triggera few sections above.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
tikv-configuration-file.mdline ~1767 onrelease-8.5AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit
soft-pending-compaction-bytes-limitsetting in v8.5.5 to accurately explain when its value overrides the storage flow-control threshold.