i18n(ja): unify configuration file/parameter terminology (part 2/2) - #23833
Open
yahonda wants to merge 2 commits into
Open
i18n(ja): unify configuration file/parameter terminology (part 2/2)#23833yahonda wants to merge 2 commits into
yahonda wants to merge 2 commits into
Conversation
Split from a single branch that grew past CodeRabbit's 150-file review limit (265 files total). This is part 2/2, containing the remaining 132 files; part 1/2 is a separate PR with the other 133 files. Both parts are byte-identical to the original branch's content for their respective file subsets. Unifies the multi-way split rendering of "configuration" (file, parameter, item, flag, option, and other compounds, plus standalone/ bare use) across the corpus, consistent with the already-decided direction for configuration item/parameter/option compounds (PR pingcap#23596). Also includes several literal-identifier and false-friend fixes found during review (Grafana/TiDB Dashboard UI labels wrongly translated, a config-item key mistranslated as prose, a mistranslated table header, more natural table headers). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
6 tasks
ti-chi-bot
Bot
added
missing-translation-status
6 tasks
|
Warning Review limit reachedNext included review available in 13 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (132)
📝 WalkthroughWalkthroughThis documentation-only change standardizes Japanese terminology by replacing inconsistent configuration-related wording with settings-related wording across release notes, TiDB documentation, TiDB Cloud documentation, and component references. Technical content, links, anchors, and behavior remain unchanged. ChangesJapanese terminology normalization
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~10 minutes Suggested reviewers: Merge Risk: 🟡 Moderate · up to The migration instructions can leave operators unclear about a required setting comparison and lead to a failed BR restore. Clarify that instruction before merge; the other findings are localized documentation corrections. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 12
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
storage-engine/titan-configuration.md (1)
112-112: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winComplete the configuration terminology normalization.
The changed text standardizes
設定, but the following locations still use構成for the same concept:
storage-engine/titan-configuration.md#L112-L112: changeTitanの構成例toTitanの設定例.storage-engine/titan-configuration.md#L15-L15: change元の構成to元の設定.storage-engine/titan-configuration.md#L33-L33: change構成を変更するto設定を変更する.ticdc/ticdc-server-config.md#L6-L6: changeTiCDC サーバー構成toTiCDC サーバー設定.ticdc/ticdc-server-config.md#L17-L17: changeTiCDC Changefeed構成toTiCDC Changefeed設定.ticdc/ticdc-integrity-check.md#L46-L46: apply the committable replacement from that file's review comment.As per path instructions, this Markdown feedback is specific and actionable. As per the PR objective, configuration-related Japanese terminology must be standardized across the documentation.
Source: Path instructions
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: f1b5c1f2-51e3-4b76-95a9-9f69caff9b07
📒 Files selected for processing (132)
releases/release-6.5.0.mdreleases/release-6.5.1.mdreleases/release-6.5.6.mdreleases/release-6.6.0.mdreleases/release-7.0.0.mdreleases/release-7.1.0.mdreleases/release-7.1.3.mdreleases/release-7.2.0.mdreleases/release-7.3.0.mdreleases/release-7.4.0.mdreleases/release-7.5.0.mdreleases/release-7.6.0.mdreleases/release-8.0.0.mdreleases/release-8.1.0.mdreleases/release-8.2.0.mdreleases/release-8.3.0.mdreleases/release-8.4.0.mdreleases/release-8.5.0.mdreleases/release-8.5.4.mdreleases/release-8.5.5.mdreleases/release-8.5.6.mdreleases/release-8.5.7.mdreplicate-between-primary-and-secondary-clusters.mdreplicate-data-to-kafka.mdresources/doc-templates/template-task.mdscale-microservices-using-tiup.mdscale-tidb-using-tiup.mdschedule-replicas-by-topology-labels.mdscheduling-configuration-file.mdsql-statements/sql-statement-import-into.mdsql-statements/sql-statement-lock-tables-and-unlock-tables.mdsql-statements/sql-statement-split-region.mdstatement-summary-tables.mdstorage-engine/titan-configuration.mdsync-diff-inspector/sync-diff-inspector-overview.mdsystem-variable-reference.mdsystem-variables.mdthree-data-centers-in-two-cities-deployment.mdticdc-deployment-topology.mdticdc/deploy-ticdc.mdticdc/integrate-confluent-using-ticdc.mdticdc/ticdc-architecture.mdticdc/ticdc-bidirectional-replication.mdticdc/ticdc-changefeed-config.mdticdc/ticdc-classic-architecture.mdticdc/ticdc-ddl.mdticdc/ticdc-faq.mdticdc/ticdc-integrity-check.mdticdc/ticdc-manage-changefeed.mdticdc/ticdc-open-api-v2.mdticdc/ticdc-server-config.mdticdc/ticdc-sink-to-kafka.mdticdc/ticdc-sink-to-mysql.mdticdc/ticdc-sink-to-pulsar.mdticdc/ticdc-upstream-downstream-check.mdticdc/troubleshoot-ticdc.mdtidb-cloud/csv-config-for-import-data.mdtidb-cloud/data-service-app-config-files.mdtidb-cloud/data-service-concepts.mdtidb-cloud/data-service-get-started.mdtidb-cloud/data-service-manage-data-app.mdtidb-cloud/data-service-manage-github-connection.mdtidb-cloud/integrate-tidbcloud-with-dbt.mdtidb-cloud/migrate-from-mysql-using-data-migration.mdtidb-cloud/migrate-from-op-tidb.mdtidb-cloud/migrate-sql-shards.mdtidb-cloud/optimize-resource-allocation.mdtidb-cloud/premium/migrate-from-op-tidb-premium.mdtidb-cloud/setup-azure-self-hosted-kafka-private-link-service.mdtidb-cloud/terraform-migrate-cluster-resource.mdtidb-cloud/terraform-tidbcloud-provider-overview.mdtidb-cloud/terraform-use-cluster-resource.mdtidb-cloud/terraform-use-dedicated-cluster-resource.mdtidb-cloud/terraform-use-dedicated-network-container-resource.mdtidb-cloud/terraform-use-dedicated-private-endpoint-connection-resource.mdtidb-cloud/terraform-use-dedicated-vpc-peering-resource.mdtidb-cloud/terraform-use-serverless-branch-resource.mdtidb-cloud/terraform-use-serverless-cluster-resource-manage-essential.mdtidb-cloud/terraform-use-serverless-cluster-resource.mdtidb-cloud/terraform-use-serverless-export-resource.mdtidb-cloud/terraform-use-sql-user-resource.mdtidb-cloud/ticloud-config-edit.mdtidb-cloud/ticloud-serverless-audit-log-config-describe.mdtidb-cloud/ticloud-serverless-audit-log-config-update.mdtidb-cloud/ticloud-serverless-audit-log-download.mdtidb-cloud/ticloud-serverless-audit-log-filter-rule-create.mdtidb-cloud/ticloud-serverless-audit-log-filter-rule-delete.mdtidb-cloud/ticloud-serverless-audit-log-filter-rule-describe.mdtidb-cloud/ticloud-serverless-audit-log-filter-rule-list.mdtidb-cloud/ticloud-serverless-audit-log-filter-rule-template.mdtidb-cloud/ticloud-serverless-audit-log-filter-rule-update.mdtidb-cloud/tidb-cloud-connect-aws-dms.mdtidb-cloud/tidb-cloud-dm-precheck-and-troubleshooting.mdtidb-cloud/tidb-cloud-performance-reference.mdtidb-cloud/v8.5-performance-highlights.mdtidb-configuration-file.mdtidb-lightning/data-import-best-practices.mdtidb-lightning/import-into-vs-tidb-lightning.mdtidb-lightning/tidb-lightning-compatibility-and-scenarios.mdtidb-lightning/tidb-lightning-configuration.mdtidb-lightning/tidb-lightning-data-source.mdtidb-lightning/tidb-lightning-distributed-import.mdtidb-lightning/tidb-lightning-faq.mdtidb-lightning/tidb-lightning-logical-import-mode-usage.mdtidb-performance-tuning-config.mdtidb-upgrade-migration-guide.mdtiflash-deployment-topology.mdtiflash/create-tiflash-replicas.mdtiflash/tiflash-command-line-flags.mdtiflash/tiflash-configuration.mdtiflash/tiflash-disaggregated-and-s3.mdtikv-configuration-file.mdtikv-control.mdtiproxy/tiproxy-command-line-flags.mdtiproxy/tiproxy-configuration.mdtiproxy/tiproxy-deployment-topology.mdtiproxy/tiproxy-overview.mdtiproxy/tiproxy-performance-test.mdtiup/customized-montior-in-tiup-environment.mdtiup/tiup-cluster-no-sudo-mode.mdtiup/tiup-cluster-topology-reference.mdtiup/tiup-command-telemetry.mdtiup/tiup-component-cluster-deploy.mdtiup/tiup-component-cluster-import.mdtiup/tiup-component-cluster-patch.mdtiup/tiup-component-cluster-upgrade.mdtiup/tiup-component-dm-patch.mdtiup/tiup-dm-topology-reference.mdtso-configuration-file.mdtwo-data-centers-in-one-city-deployment.mdupgrade-tidb-using-tiup.mduser-account-management.md
Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review.
…ration-term inconsistencies Each finding was individually verified against its EN source before fixing (not blindly applied). 13 files: - releases/release-6.5.1.md, schedule-replicas-by-topology-labels.md: dropped は/と/を particles, unrelated to the configuration-term sweep - ticdc/ticdc-bidirectional-replication.md, ticdc/ticdc-sink-to-pulsar.md, tidb-cloud/data-service-concepts.md, tidb-cloud/data-service-manage-github-connection.md, tidb-cloud/data-service-manage-data-app.md, tidb-cloud/optimize-resource-allocation.md, tidb-cloud/terraform-migrate-cluster-resource.md, tidb-cloud/tidb-cloud-dm-precheck-and-troubleshooting.md: same-file or cross-file leftover uses of the old configuration terminology that this sweep's substring replacement could not catch, since they used a different source word than the ones targeted - tidb-cloud/data-service-app-config-files.md: unrelated malformed sentence (stray leading word, doubled past-tense marker), link target preserved - tidb-upgrade-migration-guide.md, tikv-configuration-file.md: unrelated clarity issues restructured per EN source Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Member
Author
|
@coderabbitai full review |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First-time contributors' checklist
What is changed, added or deleted? (Required)
Part 2/2 of #23828, split to stay under CodeRabbit's 150-file review limit (the original branch grew to 265 files across 7 review-driven follow-up commits). This PR contains the remaining 132 of those files; part 1/2 is #23832 with the other 133. Both parts are byte-identical to #23828's final content for their respective file subsets — verified via a SHA comparison against every file in both splits.
Unifies the multi-way split rendering of "configuration" (file, parameter, item, flag, option, and other compounds, plus standalone/bare use) across the corpus, consistent with the already-decided direction for configuration item/parameter/option compounds (PR #23596). Also includes several literal-identifier and false-friend fixes found during review of #23828 (Grafana/TiDB Dashboard UI labels wrongly translated to Japanese, a config-item key mistranslated as prose instead of kept literal, a mistranslated table header, more natural table header wording).
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit