Skip to content

Conversation

@TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Apr 29, 2020

What is changed, added or deleted? (Required)

Refine the command and language of SQL diagnosis-related system table documents.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@TomShawn TomShawn added type/bugfix This PR fixes a bug. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. status/PTAL This PR is ready for reviewing. needs-cherry-pick-4.0 labels Apr 29, 2020
@TomShawn TomShawn requested review from lilin90 and reafans April 29, 2020 12:56
@sre-bot
Copy link
Contributor

sre-bot commented May 1, 2020

@lilin90, @reafans, PTAL.

2 similar comments
@sre-bot
Copy link
Contributor

sre-bot commented May 3, 2020

@lilin90, @reafans, PTAL.

@sre-bot
Copy link
Contributor

sre-bot commented May 6, 2020

@lilin90, @reafans, PTAL.

Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 added the status/can-merge Indicates a PR has been approved by a committer. label May 8, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 8, 2020

/run-all-tests

@sre-bot sre-bot merged commit 521314b into pingcap:master May 8, 2020
@TomShawn TomShawn deleted the refine-sql-diagnosis branch May 8, 2020 13:12
sre-bot pushed a commit to sre-bot/docs that referenced this pull request May 8, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 8, 2020

cherry pick to release-4.0 in PR #2493

sre-bot added a commit that referenced this pull request May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/bugfix This PR fixes a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants