-
Notifications
You must be signed in to change notification settings - Fork 709
how-to: add check-before-deployment.md #2656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
check-before-deployment.md
Outdated
| sysctl -p | ||
| ``` | ||
|
|
||
| ## Check and stop the firewall service of deployment machines |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ## Check and stop the firewall service of deployment machines | |
| ## Check and stop the firewall service of target machines |
In docs-cn repo, @kissmydb once suggested that we unify the terms and use "中控机" and "目标机器" (instead of "部署机"). So in docs repo, I suggest we use "Control Machine" and "Target Machine" (instead of "deployment machine") across our documents. @ran-huang Please update all places that apply to this suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
… into check-before-deploy
|
@yikeke Comments addressed. PTAL~ |
check-before-deployment.md
Outdated
|
|
||
| This section describes how to manually configure the SSH mutual trust and sudo without password. It is recommended to use TiUP for deployment, which automatically configure SSH mutual trust and login without password. If you deploy TiDB clusters using TiUP, ignore this section. | ||
|
|
||
| 1. Log in to the Target Machine respectively using the `root` user account, create the `tidb` user and set the login password. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 1. Log in to the Target Machine respectively using the `root` user account, create the `tidb` user and set the login password. | |
| 1. Log in to the target machines respectively using the `root` user account, create the `tidb` user and set the login password. |
s/Target Machine/target machine in batch @ran-huang
I think "control machine" and "target machine" can both use the lowercase form, what do you think? @ran-huang
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yikeke Personally I think either uppercase or lowercase is okay. Now we use mostly Control Machine and target machine in our docs. Better unify them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We take the lowercase form then. Can you help unify the terms across our docs in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
yikeke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
|
@yikeke The two terms are unified. PTAL. |
yikeke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
|
/merge |
|
/run-all-tests |
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-4.0 in PR #2680 |
* cherry pick #2656 to release-4.0 Signed-off-by: sre-bot <sre-bot@pingcap.com> * resolve 3 conflicts * Update upgrade-tidb-using-ansible.md Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: Ran <huangran@pingcap.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
What is changed, added or deleted? (Required)
Add check-before-deployment.md
Which TiDB version(s) do your changes apply to? (Required)
If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.
What is the related PR or file link(s)?