-
Notifications
You must be signed in to change notification settings - Fork 709
Add TiDB Dashboard documents #2668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Wenxuan <hi@breeswish.org>
breezewish
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest LGTM
Co-authored-by: Wenxuan <hi@breeswish.org>
HunDunDM
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Please help review this PR, thanks~ @ran-huang |
ran-huang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the first two docs. I'll come back later to review the rest.
dashboard/dashboard-overview.md
Outdated
|
|
||
| ## Access the page | ||
|
|
||
| After logging into TiDB Dashboard, the overview page is entered by default, or you can click **Overview** on the left navigation bar to enter this page: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"navigation menu" or "bar"? "menu" is used in dashboard cluster-info.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
menu is right.
Co-authored-by: Ran <huangran@pingcap.com>
|
@ran-huang Comments addressed, PTAL again, thanks! |
ran-huang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/run-all-tests |
|
/run-cherry-picker |
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-4.0 in PR #2758 |
What is changed, added or deleted? (Required)
Add five TiDB Dashboard documents:
This PR must be merged after #2690.
Which TiDB version(s) do your changes apply to? (Required)
If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.
What is the related PR or file link(s)?