Skip to content

Conversation

@TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Jun 3, 2020

What is changed, added or deleted? (Required)

Add five TiDB Dashboard documents:

  • 概况页面
  • 集群信息页面
  • SQL 语句分析页面
  • 查看执行详情
  • 慢查询页面

This PR must be merged after #2690.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@TomShawn TomShawn added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-4.0 labels Jun 3, 2020
Co-authored-by: Wenxuan <hi@breeswish.org>
Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM

Co-authored-by: Wenxuan <hi@breeswish.org>
Copy link
Contributor

@HunDunDM HunDunDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke requested review from ran-huang and removed request for yikeke June 8, 2020 10:19
@yikeke
Copy link
Contributor

yikeke commented Jun 8, 2020

Please help review this PR, thanks~ @ran-huang

Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the first two docs. I'll come back later to review the rest.


## Access the page

After logging into TiDB Dashboard, the overview page is entered by default, or you can click **Overview** on the left navigation bar to enter this page:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"navigation menu" or "bar"? "menu" is used in dashboard cluster-info.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

menu is right.

TomShawn and others added 2 commits June 9, 2020 14:11
Co-authored-by: Ran <huangran@pingcap.com>
@TomShawn
Copy link
Contributor Author

TomShawn commented Jun 9, 2020

@ran-huang Comments addressed, PTAL again, thanks!

Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn added status/can-merge Indicates a PR has been approved by a committer. and removed status/DNM labels Jun 9, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jun 9, 2020

/run-all-tests

@TomShawn TomShawn merged commit 67d98e9 into pingcap:master Jun 9, 2020
@TomShawn
Copy link
Contributor Author

TomShawn commented Jun 9, 2020

/run-cherry-picker

sre-bot pushed a commit to sre-bot/docs that referenced this pull request Jun 9, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot mentioned this pull request Jun 9, 2020
5 tasks
@sre-bot
Copy link
Contributor

sre-bot commented Jun 9, 2020

cherry pick to release-4.0 in PR #2758

@TomShawn TomShawn deleted the dashboard-2 branch June 9, 2020 12:14
sre-bot added a commit that referenced this pull request Jun 9, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants