Skip to content

Add TiDB limitations #2899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 16, 2020
Merged

Add TiDB limitations #2899

merged 6 commits into from
Jun 16, 2020

Conversation

@TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Jun 16, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Add TiDB limitations.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@TomShawn TomShawn added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-4.0 special-week PR from Document Special Week. labels Jun 16, 2020
@TomShawn TomShawn requested review from kissmydb, scsldb and yikeke June 16, 2020 07:06
@yikeke yikeke requested a review from lilin90 June 16, 2020 07:06
@yikeke yikeke removed their request for review June 16, 2020 07:32
lilin90
lilin90 reviewed Jun 16, 2020
View reviewed changes
tidb-limitations.md Outdated
@@ -0,0 +1,74 @@
---
title: TiDB Limitations
summary: Learn the limitations of TiDB.
Copy link
Member

@lilin90 lilin90 Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
summary: Learn the limitations of TiDB.
summary: Learn the usage limitations of TiDB.

tidb-limitations.md Outdated

# TiDB Limitations

This document describes the common limitations of TiDB, including the maximum identifier length and the maximum count of supported databases, tables, indexes, partitioned tables, and sequences.
Copy link
Member

@lilin90 lilin90 Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This document describes the common limitations of TiDB, including the maximum identifier length and the maximum count of supported databases, tables, indexes, partitioned tables, and sequences.
This document describes the common usage limitations of TiDB, including the maximum identifier length and the maximum number of supported databases, tables, indexes, partitioned tables, and sequences.

tidb-limitations.md Outdated

This document describes the common limitations of TiDB, including the maximum identifier length and the maximum count of supported databases, tables, indexes, partitioned tables, and sequences.

## Limitation on identifier length
Copy link
Member

@lilin90 lilin90 Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Limitation on identifier length
## Limitations on identifier length

tidb-limitations.md Outdated

## Limitation on identifier length

| Identifier type | Maximum length (character) |
Copy link
Member

@lilin90 lilin90 Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Identifier type | Maximum length (character) |
| Identifier type | Maximum length (number of characters allowed) |

tidb-limitations.md Outdated
| View | 64 |
| Sequence | 64 |

## Limitation on the total count of databases, tables, views, and connections
Copy link
Member

@lilin90 lilin90 Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Limitation on the total count of databases, tables, views, and connections
## Limitations on the total number of databases, tables, views, and connections

tidb-limitations.md Outdated
Comment on lines 47 to 59
## Limitation on a single row

| Type | Upper limit |
|:----------|:----------|
| Size | 6 MB |

## Limitation on a single column

| Type | Upper limit |
|:----------|:----------|
| Size | 6 MB |

## Limitation on string types
Copy link
Member

@lilin90 lilin90 Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Member

@lilin90 lilin90 Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this context, the plural form of limitation is more commonly used. Please pay attention to this word.

tidb-limitations.md Outdated
| BINARY | 256 characters |
| VARBINARY | 65535 characters |
| VARCHAR | 16383 characters |
| TEXT | 6MB bytes |
Copy link
Member

@lilin90 lilin90 Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| TEXT | 6MB bytes |
| TEXT | 6 MB bytes |

tidb-limitations.md Outdated
| VARBINARY | 65535 characters |
| VARCHAR | 16383 characters |
| TEXT | 6MB bytes |
| BLOB | 6MB bytes |
Copy link
Member

@lilin90 lilin90 Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

tidb-limitations.md Outdated
| TEXT | 6MB bytes |
| BLOB | 6MB bytes |

## Limitation on SQL statements
Copy link
Member

@lilin90 lilin90 Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

tidb-limitations.md Outdated

| Type | Upper limit |
|:----------|:----------|
| The number of SQL statements in a single transaction | When the optimistic transaction is used and the transaction retry is enabled, the default upper limit is 5000, which can be changed through [`stmt-count-limit`](/tidb-configuration-file.md#stmt-count-limit). |
Copy link
Member

@lilin90 lilin90 Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some meaning is missed. Try to be clearer in each column.

Suggested change
| The number of SQL statements in a single transaction | When the optimistic transaction is used and the transaction retry is enabled, the default upper limit is 5000, which can be changed through [`stmt-count-limit`](/tidb-configuration-file.md#stmt-count-limit). |
| The maximum number of SQL statements in a single transaction | When the optimistic transaction is used and the transaction retry is enabled, the default upper limit is 5000, which can be modified using [`stmt-count-limit`](/tidb-configuration-file.md#stmt-count-limit). |

@lilin90 lilin90 added the status/require-change Needs the author to address comments. label Jun 16, 2020
@TomShawn TomShawn added status/PTAL This PR is ready for reviewing. and removed status/require-change Needs the author to address comments. labels Jun 16, 2020
@TomShawn
Copy link
Contributor Author

TomShawn commented Jun 16, 2020 •
edited
Loading

@lilin90 Comments addressed, PTAL again, thanks!

lilin90
lilin90 reviewed Jun 16, 2020
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment was ignored.

lilin90
lilin90 approved these changes Jun 16, 2020
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90
Copy link
Member

lilin90 commented Jun 16, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 16, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 16, 2020

/run-all-tests

@ti-srebot ti-srebot merged commit bf258db into pingcap:master Jun 16, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jun 16, 2020
@TomShawn @ti-srebot
cherry pick pingcap#2899 to release-4.0
51b3685 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 16, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 16, 2020

cherry pick to release-4.0 in PR #2916

lilin90 pushed a commit that referenced this pull request Jun 16, 2020
@ti-srebot @TomShawn
cherry pick #2899 to release-4.0 (#2916)
00bd9ce 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lilin90 lilin90 lilin90 approved these changes

@scsldb scsldb Awaiting requested review from scsldb

@kissmydb kissmydb Awaiting requested review from kissmydb

Assignees

No one assigned

Labels

special-week PR from Document Special Week. status/can-merge Indicates a PR has been approved by a committer. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TomShawn @lilin90 @ti-srebot @yikeke